Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Load SwiftLint version in the Package Description #351

Merged
merged 3 commits into from
Feb 26, 2024

Conversation

iangmaia
Copy link
Contributor

This PR is a simple experiment on loading the right SwiftLint version defined in .swiftlint.yml in the Package Description.
I have refrained from using a proper YAML parser to keep it simple, so I just load the file and parse it as a string.

I don't have many ideas on sharing this code to use in other repos, but perhaps it also isn't a big deal to replicate it as needed.


  • I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

@iangmaia iangmaia requested a review from mokagio February 23, 2024 16:24
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ Package.swift was changed without updating its corresponding Package.resolved. Please resolve the Swift packages in Xcode.

Generated by 🚫 Danger

Copy link
Contributor

@mokagio mokagio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. I tried changing the version locally and it did indeed fetch the new one. 👍

Package.swift Outdated Show resolved Hide resolved
Base automatically changed from iangmaia/swiftlint-version-ci to trunk February 26, 2024 14:21
@iangmaia iangmaia marked this pull request as ready for review February 26, 2024 14:22
@iangmaia iangmaia merged commit 2298da4 into trunk Feb 26, 2024
10 checks passed
@iangmaia iangmaia deleted the iangmaia/prototype-load-swiftlint-version-on-spm branch February 26, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants