Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kitsu-core): use typeof instead of constructor comparison for checking if Object #654

Merged
merged 4 commits into from
Mar 4, 2022

Conversation

wopian
Copy link
Owner

@wopian wopian commented Mar 4, 2022

Closes #652

@codeclimate
Copy link

codeclimate bot commented Mar 4, 2022

Code Climate has analyzed commit 8d39707 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

@wopian wopian merged commit af9d893 into master Mar 4, 2022
@wopian wopian deleted the refactor/typeof branch March 4, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Object type checking might fail in nuxt applications
1 participant