Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AN] fix: 채팅 알림 이미지가 빈 문자열 에러처리 #717

Merged
merged 3 commits into from
Oct 23, 2024
Merged

[AN] fix: 채팅 알림 이미지가 빈 문자열 에러처리 #717

merged 3 commits into from
Oct 23, 2024

Conversation

gaeun5744
Copy link
Member

이슈

개발 사항

  • 빈 문자열일 경우, 기본이미지 보임

jimi567
jimi567 approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@jimi567 jimi567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

ehtjsv2
ehtjsv2 previously approved these changes Oct 23, 2024
View reviewed changes
jimi567
jimi567 requested changes Oct 23, 2024
View reviewed changes
Copy link
Member

@jimi567 jimi567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

log는 뭔가요ㅕ..?

J-I-H-O
J-I-H-O requested changes Oct 23, 2024
View reviewed changes
android/app/src/main/java/com/happy/friendogly/presentation/ui/chatlist/chat/ChatViewModel.kt Outdated
Comment on lines 67 to 68
Log.d("테스트", "$newMessage")

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

불필요한 출력문은 제거해주세요.

@github-actions GitHub Actions
Copy link

Test Results

60 tests  ±0   60 ✅ ±0   1s ⏱️ ±0s
 9 suites ±0    0 💤 ±0 
 9 files   ±0    0 ❌ ±0 

Results for commit 32e8737. ± Comparison against base commit bd551e9.

jimi567
jimi567 approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@jimi567 jimi567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하쎳어여

@gaeun5744 gaeun5744 merged commit 4cbc0db into develop Oct 23, 2024
2 checks passed
@takoyakimchi takoyakimchi deleted the fix/chat-image-blank branch November 4, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-I-H-O J-I-H-O J-I-H-O approved these changes

@takoyakimchi takoyakimchi takoyakimchi approved these changes

@jimi567 jimi567 jimi567 approved these changes

@ehtjsv2 ehtjsv2 ehtjsv2 left review comments

@dpcks0509 dpcks0509 Awaiting requested review from dpcks0509 dpcks0509 is a code owner

@jinuemong jinuemong Awaiting requested review from jinuemong jinuemong is a code owner

@junjange junjange Awaiting requested review from junjange junjange is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

채팅 알림 이미지가 빈 문자열일 경우, 예외 처리
5 participants
@gaeun5744 @jimi567 @takoyakimchi @ehtjsv2 @J-I-H-O