Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

멍개 상세 ui 구현 #49

Closed
wants to merge 8 commits into from
Closed

멍개 상세 ui 구현 #49

wants to merge 8 commits into from

Conversation

jinuemong
Copy link
Contributor

이슈

개발 사항

  • 멍개 상세 ui 구현했습니다.
  • viewModel 생성 후 연결하였습니다.

전달 사항

  • 폰트 관련해서 일단 적용 안했는데, 디자인 구체화 작업으로 적용할 예정입니다.
  • 이전 pr 관련 ui가 있어서 TODO 달았습니다 !

@jinuemong jinuemong changed the title Feature/group detail 멍개 상세 ui 구현 Jul 14, 2024
@jinuemong jinuemong self-assigned this Jul 14, 2024
@jinuemong jinuemong added 🤖 android android ✨ feat 기능 개발 labels Jul 14, 2024
Copy link

Test Results

3 tests  ±0   3 ✅ ±0   0s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 83ad271. ± Comparison against base commit 9180143.

Comment on lines 21 to 30
<ImageView
android:id="@+id/group_detail_image"
android:layout_width="0dp"
android:layout_height="0dp"
android:background="@color/black"
android:scaleType="centerCrop"
app:layout_constraintDimensionRatio="1:1"
app:layout_constraintLeft_toLeftOf="parent"
app:layout_constraintRight_toRightOf="parent"
app:layout_constraintTop_toTopOf="parent" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

팀 컨벤션 확인해주세요!!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

웁스 죄송해요 ~

Copy link
Member

@junjange junjange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!!🫡
전체적으로 xml 팀 컨벤션 확인해주세여~~

dpcks0509
dpcks0509 previously approved these changes Jul 14, 2024
Copy link
Contributor

@dpcks0509 dpcks0509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다아! id 값 팀 컨벤션만 수정해주시면 좋을 것 같아요!!

Comment on lines +14 to +15
<string name="group_user_list_subject">참여 견주</string>
<string name="group_dog_list_subject">댕댕이들</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strings.xml 활용 좋습니다!!👍

gaeun5744
gaeun5744 previously approved these changes Jul 15, 2024
Copy link
Member

@gaeun5744 gaeun5744 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿

@jinuemong jinuemong dismissed stale reviews from gaeun5744 and dpcks0509 via 1a2ae77 July 15, 2024 09:11
@jinuemong jinuemong closed this by deleting the head repository Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 android android ✨ feat 기능 개발
Projects
None yet
Development

Successfully merging this pull request may close these issues.

멍개 상세 UI
4 participants