Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

공지사항 생성, 수정, 삭제 시 캐시 초기화 로직 변경 #802

Merged
merged 3 commits into from
Oct 19, 2023
Merged

공지사항 생성, 수정, 삭제 시 캐시 초기화 로직 변경 #802

merged 3 commits into from
Oct 19, 2023

Conversation

Gilpop8663
Copy link
Collaborator

🔥 연관 이슈

close: #801

📝 작업 요약

  • 공지사항 생성, 수정, 삭제 후 캐시 초기화 로직 변경

📆 소요시간

5분

📃 세부 사항

쿼리키의 첫번째 값이 공지사항이라면 전부 초기화하도록 했습니다

그 이유는 notice만 초기화 했을 때 수정,삭제 시 배너, 페이지를 사용하는 공지사항 리스트가 변하지 않을것 같아서요

@Gilpop8663 Gilpop8663 self-assigned this Oct 19, 2023
@Gilpop8663 Gilpop8663 changed the title fix: (#801) 공지사항 생성, 수정, 삭제 시 캐시 초기화 로직 변경 공지사항 생성, 수정, 삭제 시 캐시 초기화 로직 변경 Oct 19, 2023
chsua
chsua approved these changes Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@chsua chsua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

세심한 우스 감사합니다!!!

@github-actions
Copy link

github-actions bot commented Oct 19, 2023 •
edited
Loading

⚡️ Lighthouse report!

Category Score
🟠 Performance 70
🟠 Accessibilty 89
🟢 SEO 100
🟠 PWA 89
Category Score
🟢 First Contentful Paint 0.6 s
🟠 Largest Contentful Paint 3.0 s
🔴 Total Blocking Time 1,190 ms
🟢 Cumulative Layout Shift 0.046
🟢 Speed Index 2.9 s

@inyeong-kang inyeong-kang merged commit cbecb6a into dev Oct 19, 2023
1 check passed
@inyeong-kang inyeong-kang deleted the feat/#801 branch October 19, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chsua chsua chsua approved these changes

@inyeong-kang inyeong-kang inyeong-kang approved these changes

Assignees

@Gilpop8663 Gilpop8663

Labels
FE 🐛 버그
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

공지사항 생성, 수정, 삭제 후 캐시 초기화 로직 변경
3 participants
@Gilpop8663 @inyeong-kang @chsua