[BUG] 모바일 비회원일 때 신고 버튼을 눌르면 알 수 없는 에러 메세지입니다라고 떠요 #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 기존 fetch에서 리액트쿼리 훅으로 교체
- PostAction 설정
|
⚡️ Lighthouse report!
|
inyeong-kang
requested changes
Oct 18, 2023
| !isReportLoading && handleReportClick(selectedOption); | ||
| if (isReportLoading) return; | ||
|
|
||
| handleReportClick(selectedOption); |
There was a problem hiding this comment.
로딩이 끝나야만 action을 null로 세팅하도록 해서
말씀하신 이슈를 해결해볼 수 있을거 같아요!
There was a problem hiding this comment.
혹시 그럼 네트워크가 느린 사용자가 신고를 하고 기다리다가 오래 걸려서 취소를 누르면 나가지지 않게 될 것 같은데 제가 이해한 바가 맞을까요?? 아님 다르게 작동하나요??
| @@ -16,7 +21,8 @@ export const useReportAction = () => { | |||
| queryClient.invalidateQueries({ queryKey: [QUERY_KEY.REPORT] }); | |||
| }, | |||
| onError: () => { | |||
| window.console.error('신고 조치를 실패했습니다.'); | |||
| const message = error instanceof Error ? error.message : '투표를 실패했습니다.'; | |||
| addMessage(message); | |||
There was a problem hiding this comment.
복붙 때문인지 에러메시지 값이 이상해졌는데 복구해주실 수 있나요🤔
|
fe-리뷰완 |
Gilpop8663
approved these changes
Oct 18, 2023
| mutationFn: async (reportData: ReportRequest) => await reportContent(reportData), | ||
| onSuccess: () => { | ||
| queryClient.invalidateQueries({ queryKey: [QUERY_KEY.REPORT] }); | ||
| addMessage('신고를 완료하였습니다.'); |
There was a problem hiding this comment.
신고의 경우에는 성공했을 때 사용자에게 알려주는 것 너무 좋은데여🔥
Comment on lines
+62
to
+65
| if (!loggedInfo.isLoggedIn) { | ||
| openToast('로그인 후에 기능을 이용해주세요.'); | ||
| return; | ||
| } |
|
fe-리뷰완 |
|
FE-리뷰요청 |
inyeong-kang
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 연관 이슈
close: #734
📝 작업 요약
⏰ 소요 시간
1시간
🔎 작업 상세 설명
🌟 논의 사항
신고하기 mutate를 게시글/닉네임 같이 사용하는데 문제가 되진 않겠죠?