Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

작성글/투표글 텍스트 스타일링 수정 및 뒤로가기 버튼 이슈 해결, 댓글 textarea의 placeholder font 수정 #676

Merged
merged 7 commits into from
Sep 21, 2023

Conversation

inyeong-kang
Copy link
Member

@inyeong-kang inyeong-kang commented Sep 21, 2023

🔥 연관 이슈

close: #671
close: #672

📝 작업 요약

  • 작성글/투표글 텍스트 스타일링함.
  • 뒤로가기 버튼 이슈 해결함.
  • 댓글 textarea의 placeholder font를 수정함

⏰ 소요 시간

1시간 30분

🔎 작업 상세 설명

  • 기존의 밑줄을 없애고 화살표 아이콘을 추가하였습니다.
    image
  • 뒤로가기 버튼을 눌렀을 때 이전 url이 없는 경우 홈으로 라우팅하였습니다.
  • 댓글 textarea의 placeholder의 크기를 줄였습니다.

🌟 논의 사항

없음

@github-actions
Copy link

github-actions bot commented Sep 21, 2023

⚡️ Lighthouse report!

Category Score
🟠 Performance 72
🟠 Accessibilty 89
🟢 SEO 100
🟠 PWA 89
Category Score
🟢 First Contentful Paint 0.6 s
🟠 Largest Contentful Paint 3.0 s
🔴 Total Blocking Time 1,030 ms
🟢 Cumulative Layout Shift 0
🟢 Speed Index 2.9 s

Copy link
Collaborator

@Gilpop8663 Gilpop8663 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

너무 좋네요! 어프로브 하도록 하겠습니다

Comment on lines +68 to +73
if (window.history.length > 1) {
navigate(-1);
return;
}
navigate(PATH.HOME);
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

디테일😎 대단해용

@inyeong-kang
Copy link
Member Author

image
위 이미지처럼 수정했습니다~

@inyeong-kang
Copy link
Member Author

fe-리뷰요청

Copy link
Collaborator

@chsua chsua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

뒤로가기 버그는 생각 못했는데 발견 후 처리까지 bb 대단해요

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment