Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banner 컴포넌트, 공지사항 페이지 구현 #572

Merged
merged 4 commits into from
Sep 13, 2023
Merged

Banner 컴포넌트, 공지사항 페이지 구현 #572

merged 4 commits into from
Sep 13, 2023

Conversation

inyeong-kang
Copy link
Member

🔥 연관 이슈

close: #567

📝 작업 요약

Banner 컴포넌트, 공지사항 페이지를 구현하였습니다.

⏰ 소요 시간

  • 2시간

🔎 작업 상세 설명

Banner를 메인 홈에서 확인하면 아래와 같습니다,
image

Banner의 자세히 버튼을 눌러 공지사항 페이지로 들어가면 아래와 같습니다.
image

🌟 논의 사항

없음

Copy link
Collaborator

@Gilpop8663 Gilpop8663 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

배너를 정말 이쁘게 구현하셨네요 👍👍👍

어프로브 하겠습니다

Comment on lines 25 to 30
const { TITLE, CONTENT } = APP_LAUNCH_EVENT;
const [isBannerOpen, setBannerOpen] = useState(true);

const handleBannerClose = () => {
setBannerOpen(false);
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useToggle 사용하는 것은 어떨까요

Copy link
Member Author

@inyeong-kang inyeong-kang Sep 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

반영 완료!
fe-리뷰요청

@github-actions
Copy link

github-actions bot commented Sep 12, 2023

⚡️ Lighthouse report!

Category Score
🟠 Performance 53
🟢 Accessibilty 92
🟠 SEO 83
🟠 PWA 89
Category Score
🟢 First Contentful Paint 0.7 s
🔴 Largest Contentful Paint 5.0 s
🔴 Total Blocking Time 1,650 ms
🟢 Cumulative Layout Shift 0
🟠 Speed Index 3.9 s

@tjdtls690 tjdtls690 force-pushed the dev branch 2 times, most recently from 53f297e to a2388f1 Compare September 12, 2023 10:11
@chsua chsua merged commit 7f7148c into dev Sep 13, 2023
1 check passed
@woo-chang woo-chang deleted the feat/#567 branch September 13, 2023 07:51
@woo-chang woo-chang restored the feat/#567 branch September 13, 2023 07:52
@woo-chang woo-chang deleted the feat/#567 branch September 13, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

공지사항을 위한 배너 컴포넌트, 공지사항 페이지 만들기
3 participants