Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briandr97
approved these changes
Nov 7, 2023
Comment on lines
-181
to
+189
| is IOException -> { _throwable.value = DataThrowable.NetworkThrowable() } | ||
| is GameThrowable -> { handleGameThrowable(throwable) } | ||
| is IOException -> _throwable.value = DataThrowable.NetworkThrowable() | ||
| is GameThrowable -> handleGameThrowable(throwable) |
| NOT_ARRIVED -> { | ||
| val currentRemainingTryCount = adventure.value?.remainingTryCount ?: return | ||
| _adventure.value = adventure.value?.copy(remainingTryCount = currentRemainingTryCount - 1) | ||
| _throwable.value = throwable |
There was a problem hiding this comment.
예전에 분명히 잘 됐던 것 같은데 언제 지워졌던 걸까요..?
발견해주셔서 감사합니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
🛠️ 작업 내용
🎯 리뷰 포인트
OnAdventure의handleGameThrowable에서_throwable.value = throwable설정을 해주지 않아 남은 시도 횟수 알림이 보이지 않던 것 이였습니다. 지금은 throwable 을 설정해주어 throwable의 옵저버가 해당 변화를 인식하고 그때에 맞게 남은 횟수 토스트를 띄워 줍니다.⏳ 작업 시간
추정 시간: 1h
실제 시간: 2h
이유: 어디가 문제인지 몰라서 빙글빙글 코드 타고타고 돌고돌고 돌아다니는 여정이 생각보다 길어져서 시간이 오래 걸렸습니다.