Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krrong
requested changes
Nov 8, 2023
| @@ -203,6 +203,14 @@ class OnAdventureActivity : | |||
| } | |||
| } | |||
|
|
|||
| private fun registerLetter(message: String) { | |||
| if (message.isNotEmpty()) { | |||
| viewModel::sendLetter | |||
There was a problem hiding this comment.
P[1]
내용이 비어있는 쪽지에 대해서는 토스트 메시지가 잘 뜨네요!
하지만 내용이 잘 들어가 있는 쪽지에 대해서는 서버에 전송이 안되고 있어요!!
// before
viewModel::sendLetter
// after
viewModel.sendLetter(message)변경해야 합니다!
There was a problem hiding this comment.
wow 큰일날뻔 했네요 이야...쇼킹하군요
바로 수정했습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
🛠️ 작업 내용
🎯 리뷰 포인트
⏳ 작업 시간
추정 시간: 1h
실제 시간: 1h
이유: 차이가 많이 난다면 이유도 같이 적어주세요 :)