feat: 빈 쪽지 검증 추가 #540
Merged
feat: 빈 쪽지 검증 추가 #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dooboocookie
approved these changes
Nov 6, 2023
| @@ -28,7 +28,8 @@ public ResponseEntity<ExceptionResponse> handleBaseException(final BaseException | |||
| @ExceptionHandler({ | |||
| HttpMessageNotReadableException.class, | |||
| MethodArgumentNotValidException.class, | |||
| HttpMediaTypeNotSupportedException.class}) | |||
| HttpMediaTypeNotSupportedException.class, | |||
| MethodArgumentNotValidException.class}) | |||
There was a problem hiding this comment.
P5:
이건 추후에 바뀔 수도 있는 부분이네요.
아직 API 명세상으로
'요청 바디가 잘못됐을 때'로 퉁쳐져 있는데,
이런 특정 도메인 규칙이 있는 예외는 다른 에러 코드로 내려갈 수 있을 것 같아요!
| @@ -34,7 +36,7 @@ public LetterController(final LetterService letterService) { | |||
|
|
|||
| @PostMapping | |||
| public ResponseEntity<LetterResponse> createLetter(@Auth final PlayerRequest playerRequest, | |||
| @RequestBody final LetterRequest letterRequest) { | |||
| @Valid @RequestBody final LetterRequest letterRequest) { | |||
There was a problem hiding this comment.
P5:
저도 해당 부분에 @Valid를 사용하는 것에 대해서 매우 동의합니다.
https://mangkyu.tistory.com/174
혹시나 해서 @Valid와 @validated의 차이도 인지하고 있으면 좋을 것 같아요!!
|
|
||
| @ParameterizedTest | ||
| @ValueSource(strings = {"", " "}) | ||
| void 쪽지_등록_요청시_쪽지의_내용이_blank이면_예외가_발생한다(String message) { |
chaewon121
approved these changes
Nov 7, 2023
| @@ -34,7 +36,7 @@ public LetterController(final LetterService letterService) { | |||
|
|
|||
| @PostMapping | |||
| public ResponseEntity<LetterResponse> createLetter(@Auth final PlayerRequest playerRequest, | |||
| @RequestBody final LetterRequest letterRequest) { | |||
| @Valid @RequestBody final LetterRequest letterRequest) { | |||
Comment on lines
352
to
356
|
|
||
|
|
||
| @ParameterizedTest | ||
| @ValueSource(strings = {"", " "}) | ||
| void 쪽지_등록_요청시_쪽지의_내용이_blank이면_예외가_발생한다(String message) { |
chaewon121
reviewed
Nov 7, 2023
| @@ -28,7 +28,8 @@ public ResponseEntity<ExceptionResponse> handleBaseException(final BaseException | |||
| @ExceptionHandler({ | |||
| HttpMessageNotReadableException.class, | |||
| MethodArgumentNotValidException.class, | |||
| HttpMediaTypeNotSupportedException.class}) | |||
| HttpMediaTypeNotSupportedException.class, | |||
| MethodArgumentNotValidException.class}) | |||
There was a problem hiding this comment.
p3: @Valid가 던지는 에러가 MethodArgumentNotValidException 인데 지금 중복이네요! 하나지워도 될것같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
PR과 연관된 이슈의 번호를 작성해주세요.
closed #527🛠️ 작업 내용
PR에서 작업한 주요 내용을 적어주세요.
⏳ 작업 시간
추정 시간: 30분
실제 시간: 30분
MethodArgumentTypeMismatchException 때문에 삽질 2시간 추가..