forked from woowacourse/java-chess
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
안뇽하쇼 DB잘 모르기 때문에 날카로운 지적부탁 #13
Open
hanueleee
wants to merge
58
commits into
woowacourse-code-review-study:hanueleee
Choose a base branch
from
hanueleee:step4
base: hanueleee
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
안뇽하쇼 DB잘 모르기 때문에 날카로운 지적부탁 #13
hanueleee
wants to merge
58
commits into
woowacourse-code-review-study:hanueleee
from
hanueleee:step4
Commits on Mar 13, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ff4f19d - Browse repository at this point
Copy the full SHA ff4f19dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1bab9ff - Browse repository at this point
Copy the full SHA 1bab9ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 98598c0 - Browse repository at this point
Copy the full SHA 98598c0View commit details
Commits on Mar 23, 2023
-
[1,2단계 - 체스] 오잉(이하늘) 미션 제출합니다 (woowacourse#514)
* feat: Database 연결 Co-authored-by: hanueleee <[email protected]> * docs: 기능목록 작성 Co-authored-by: hanueleee <[email protected]> * docs: 기능목록 수정 Co-authored-by: hanueleee <[email protected]> * feat: Position 구현 Co-authored-by: hanueleee <[email protected]> * feat: Position 검증 기능 추가 Co-authored-by: hanueleee <[email protected]> * feat: Piece 추상 클래스 구현 Co-authored-by: hanueleee <[email protected]> * feat: Piece 상속하는 King,Queen,Rook,Knight,Bishop,Pawn 추가 Co-authored-by: hanueleee <[email protected]> * feat: PieceFactory 기능 구현 Co-authored-by: hanueleee <[email protected]> * feat: Board 생성 구현 Co-authored-by: hanueleee <[email protected]> * feat: Board 초기화 구현 Co-authored-by: hanueleee <[email protected]> * refactor: 패키지 이동 Co-authored-by: hanueleee <[email protected]> * feat: InputView 구현 Co-authored-by: hanueleee <[email protected]> * feat: CommandLine 구현 Co-authored-by: hanueleee <[email protected]> * fix: Board 초기화 오류 해결 Co-authored-by: hanueleee <[email protected]> * feat: Board에 Piece리스트를 반환하는 메서드 구현 Co-authored-by: hanueleee <[email protected]> * feat: Piece에 타입 필드 추가 Co-authored-by: hanueleee <[email protected]> * feat: ChessGame 구현 Co-authored-by: hanueleee <[email protected]> * feat: PieceMapper 구현 Co-authored-by: hanueleee <[email protected]> * feat: BoardDto 구현 Co-authored-by: hanueleee <[email protected]> * feat: 체스보드 출력 구현 Co-authored-by: hanueleee <[email protected]> * feat: ChessController 구현 Co-authored-by: hanueleee <[email protected]> * feat: Application 구현 Co-authored-by: hanueleee <[email protected]> * feat: 해당 좌표의 피스를 구하는 기능 구현 Co-authored-by: hanueleee <[email protected]> * feat: 좌표에서 또다른 좌표로 방향 구하는 로직 구현 Co-authored-by: hanueleee <[email protected]> * feat: 좌표에서 방향 더하는 연산 추가 Co-authored-by: hanueleee <[email protected]> * feat: 이동 경로 상에 다른 피스가 있는지 확인하는 기능 구현 Co-authored-by: hanueleee <[email protected]> * feat(Board): 목적지에 같은 색깔 피스가 있는지 확인하는 기능 구현 Co-authored-by: hanueleee <[email protected]> * feat(Board): 피스 위치 이동 기능 구현 Co-authored-by: hanueleee <[email protected]> * mission: 미션1 구현 * mission: 미션2 구현 * mission: 미션3 구현 * feat: 보드에서 말 이동 검증 구현 Co-authored-by: hanueleee <[email protected]> * feat(Piece): 피스들 구현 Co-authored-by: hanueleee <[email protected]> * feat(Position): 거리 계산하는 로직 구현 Co-authored-by: hanueleee <[email protected]> * feat(Game): 검증 후 이동하는 로직 구현 Co-authored-by: hanueleee <[email protected]> * feat(GameStatus): 게임 상태 관리 기능 구현 Co-authored-by: hanueleee <[email protected]> * feat: 게임 전체 로직 조합 Co-authored-by: hanueleee <[email protected]> * style(View): 출력 문구 수정 Co-authored-by: hanueleee <[email protected]> * refactor(BoardDto): 게임 대신 보드를 주입하는 방식으로 수정 Co-authored-by: hanueleee <[email protected]> * feat(OutputView): 에러 메세지 출력 기능 구현 Co-authored-by: hanueleee <[email protected]> * refactor(Controller): 메서드 정리 및 게임 턴 책임 분리 Co-authored-by: hanueleee <[email protected]> * refactor(EmptyPiece): 빈 피스 실행 예외 처리 Co-authored-by: hanueleee <[email protected]> * refactor: 코드 정리 Co-authored-by: hanueleee <[email protected]> * refactor(Board): 보드 리펙토링 Co-authored-by: hanueleee <[email protected]> * refactor(Game): 게임 리펙토링 Co-authored-by: hanueleee <[email protected]> * refactor: this 제거 * refactor(PieceMapper): if 대신 Map을 사용하여 분기 줄이기 * refactor(Piece): 모든 Piece 상속 클래스들의 생성자 로직을 정적 팩토리 메서드 내부로 이동(생성자 단순화) * refactor(Position): 위치 간의 방향을 계산하는 로직 수정 * refactor: 에러 메시지 상수 해제 * refactor(dto): BoardDto의 책임을 RankDto와 분배 * refactor(view): 시작 메시지를 각각 단일 상수화 * refactor: 패키지 정리 * test: PieceMapper 테스트 * refactor(Board): getPiecesAt -> findAllByRank 메소드명 수정 및 stream 제거 * refactor(ChessController): 정확한 예외클래스 지정 * refactor(Color): static메소드 해제 * refactor: 메소드 순서 정리, 코드 중복 제거 --------- Co-authored-by: echo <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 04d2e78 - Browse repository at this point
Copy the full SHA 04d2e78View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2be72aa - Browse repository at this point
Copy the full SHA 2be72aaView commit details -
refactor(Board): 메서드 분리 (getValidSourcePiece -> validateSourcePiece &…
… getPieceAtPosition)
Configuration menu - View commit details
-
Copy full SHA for be7116c - Browse repository at this point
Copy the full SHA be7116cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4516783 - Browse repository at this point
Copy the full SHA 4516783View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2910b93 - Browse repository at this point
Copy the full SHA 2910b93View commit details -
Configuration menu - View commit details
-
Copy full SHA for e0cd579 - Browse repository at this point
Copy the full SHA e0cd579View commit details -
Configuration menu - View commit details
-
Copy full SHA for bde1973 - Browse repository at this point
Copy the full SHA bde1973View commit details -
Configuration menu - View commit details
-
Copy full SHA for ef70ba7 - Browse repository at this point
Copy the full SHA ef70ba7View commit details -
Configuration menu - View commit details
-
Copy full SHA for ba54098 - Browse repository at this point
Copy the full SHA ba54098View commit details
Commits on Mar 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 405cac6 - Browse repository at this point
Copy the full SHA 405cac6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 28a4eb7 - Browse repository at this point
Copy the full SHA 28a4eb7View commit details -
Configuration menu - View commit details
-
Copy full SHA for f838cdd - Browse repository at this point
Copy the full SHA f838cddView commit details
Commits on Mar 26, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b233073 - Browse repository at this point
Copy the full SHA b233073View commit details -
Configuration menu - View commit details
-
Copy full SHA for 61b4dd3 - Browse repository at this point
Copy the full SHA 61b4dd3View commit details -
Configuration menu - View commit details
-
Copy full SHA for c5bd8a9 - Browse repository at this point
Copy the full SHA c5bd8a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for b932638 - Browse repository at this point
Copy the full SHA b932638View commit details -
Configuration menu - View commit details
-
Copy full SHA for f704664 - Browse repository at this point
Copy the full SHA f704664View commit details -
Configuration menu - View commit details
-
Copy full SHA for 910ef7c - Browse repository at this point
Copy the full SHA 910ef7cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a275dd - Browse repository at this point
Copy the full SHA 2a275ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a0a7ac - Browse repository at this point
Copy the full SHA 1a0a7acView commit details -
Configuration menu - View commit details
-
Copy full SHA for cc06f11 - Browse repository at this point
Copy the full SHA cc06f11View commit details -
Configuration menu - View commit details
-
Copy full SHA for 274c304 - Browse repository at this point
Copy the full SHA 274c304View commit details -
Configuration menu - View commit details
-
Copy full SHA for 41754a1 - Browse repository at this point
Copy the full SHA 41754a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b996e0 - Browse repository at this point
Copy the full SHA 6b996e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2fce195 - Browse repository at this point
Copy the full SHA 2fce195View commit details -
Configuration menu - View commit details
-
Copy full SHA for 94b94b5 - Browse repository at this point
Copy the full SHA 94b94b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f63a44 - Browse repository at this point
Copy the full SHA 5f63a44View commit details -
Configuration menu - View commit details
-
Copy full SHA for 454b4fd - Browse repository at this point
Copy the full SHA 454b4fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for a956f44 - Browse repository at this point
Copy the full SHA a956f44View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6103b07 - Browse repository at this point
Copy the full SHA 6103b07View commit details
Commits on Mar 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ec29c04 - Browse repository at this point
Copy the full SHA ec29c04View commit details -
refactor(ChessGameDao): db저장용 string을 만들고 탐색하는 과정에, enum의 name()과 val…
…ueOf()를 사용하도록 수정
Configuration menu - View commit details
-
Copy full SHA for 9f48022 - Browse repository at this point
Copy the full SHA 9f48022View commit details -
Configuration menu - View commit details
-
Copy full SHA for 37d7fd5 - Browse repository at this point
Copy the full SHA 37d7fd5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2bfd973 - Browse repository at this point
Copy the full SHA 2bfd973View commit details -
Configuration menu - View commit details
-
Copy full SHA for ffc1fdb - Browse repository at this point
Copy the full SHA ffc1fdbView commit details -
Configuration menu - View commit details
-
Copy full SHA for bb8a678 - Browse repository at this point
Copy the full SHA bb8a678View commit details -
Configuration menu - View commit details
-
Copy full SHA for f7e5b4a - Browse repository at this point
Copy the full SHA f7e5b4aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ed0147 - Browse repository at this point
Copy the full SHA 4ed0147View commit details -
Configuration menu - View commit details
-
Copy full SHA for ebeb8dc - Browse repository at this point
Copy the full SHA ebeb8dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 971e9e1 - Browse repository at this point
Copy the full SHA 971e9e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 04e132f - Browse repository at this point
Copy the full SHA 04e132fView commit details
Commits on Mar 30, 2023
-
1. 기존 public 이었던 주 생성자를 private으로 수정 2. DB로부터 Board정보를 읽어와 새로운 Board를 만들 때 사용하기 위한 정적팩토리메소드 load 추가 3. BoardGenerator의 generate결과 값으로 map이 아닌 Board를 반환하도록 수정
Configuration menu - View commit details
-
Copy full SHA for 4081add - Browse repository at this point
Copy the full SHA 4081addView commit details -
Configuration menu - View commit details
-
Copy full SHA for b654c0a - Browse repository at this point
Copy the full SHA b654c0aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 87d17fc - Browse repository at this point
Copy the full SHA 87d17fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for eb09d2e - Browse repository at this point
Copy the full SHA eb09d2eView commit details -
refactor(ChessGame): 생성자 관련 구조 수정
(기존) 2 개의 주 생성자 (현재) 1 개의 주 생성자 + 2개의 정적 팩토리 메소드
Configuration menu - View commit details
-
Copy full SHA for 84bf1a0 - Browse repository at this point
Copy the full SHA 84bf1a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for f7223bf - Browse repository at this point
Copy the full SHA f7223bfView commit details -
1. save와 updateById의 파라미터 수정 (기존) List<PieceInfoDto> (현재) PieceInfoDto 2. findById 메소드명 수정 (findById -> findAllById)
Configuration menu - View commit details
-
Copy full SHA for c2020b2 - Browse repository at this point
Copy the full SHA c2020b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 08f0dfe - Browse repository at this point
Copy the full SHA 08f0dfeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7299e31 - Browse repository at this point
Copy the full SHA 7299e31View commit details -
Configuration menu - View commit details
-
Copy full SHA for ff4fffa - Browse repository at this point
Copy the full SHA ff4fffaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 737c6cd - Browse repository at this point
Copy the full SHA 737c6cdView commit details
Commits on Mar 31, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 849bea8 - Browse repository at this point
Copy the full SHA 849bea8View commit details -
Configuration menu - View commit details
-
Copy full SHA for d409ced - Browse repository at this point
Copy the full SHA d409cedView commit details -
Configuration menu - View commit details
-
Copy full SHA for fd606fe - Browse repository at this point
Copy the full SHA fd606feView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.