forked from woowacourse/java-chess
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
레디 미션 제출 #23
Open
reddevilmidzy
wants to merge
61
commits into
woowacourse-6th-code-review-study:reddevilmidzy
Choose a base branch
from
reddevilmidzy:gear-third
base: reddevilmidzy
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
레디 미션 제출 #23
reddevilmidzy
wants to merge
61
commits into
woowacourse-6th-code-review-study:reddevilmidzy
from
reddevilmidzy:gear-third
Commits on Mar 26, 2024
-
[1,2단계 - 체스] 레디(최동근) 미션 제출합니다. (woowacourse#678)
* docs: 기능 요구 사항 작성 * feat : 8 * 8 의 체스 판 생성 * feat: 체스 말 객체 생성 * feat : 한 칸의 정보를 가진 클래스 생성 * refactor: 패키지 변경 * feat: point equals & hashCode 구현 * feat: 체스 말 배치 * feat : 검은색 말은 대문자, 흰색 말은 소문자로 표현 * refactor: message 패키지 생성 * feat: 체스 게임 시작 메시지 출력 * feat: 게임 시작(start)/종료(end) 입력 받기 * feat : end 가 입력되면 프로그램 종료 * feat: 예외 시 재입력 기능 구현 * refactor: gameBoard의 필드 객체를 Piece로 변경 * feat : 보드의 해당 위치의 기물 정보 반환 기능 구현 * refactor: 테스트 코드 메서드 명 및 디스플레이 네임 수정 * feat: move 시 기물이 없는 위치일 경우 예외 발생 기능 구현 * feat: 이동할 말의 현재 위치, 이동할 위치 입력 받기 및 말의 위치 이동 구현 * refactor: gameBoard 필드를 List<List<>> 대신 Map으로 변경 * refactor : piece에서 posotion 삭제 * feat : Pawn 움직임 가능 여부 기능 구현 * feat : Pawn 이동 기능 구현 대각선 제외 * feat : 기물 이동 GameBoard에 업데이트 * fix: 출력 시 NPE 발생하던 문제 수정 * refactor: 사용하지 않는 클래스 삭제 * feat: 시작 메시지 출력 구현 * fix: target 위치에 아무 기물이 없을 때 예외 발생 수정 * feat : Knight 이동 기능 구현 * feat: Bishop 이동 기능 구현 * feat : 게임 보드 출력 시 좌표 안내 기능 추가 * feat : Rook 이동 기능 구현 * feat: Queen 이동 기능 구현 * feat : King 이동 기능 구현 * refactor : 테스트 케이스 가독성 향상 * refactor: 추상 클래스 Piece의 불필요한 메서드 제거 * refactor: 패키지 구조 변경 * refactor: moving 클래스에서 레코드로 변경 * docs: 구현 기능 목록 추가 * feat: 현재 턴의 해당하는 진영만 이동 가능 * refactor : Position 생성자 가독성 향상을 위한 매개변수 순서 변경 * refactor : 인뎁스 1로 변환 * refactor: GameBoardDto 생성 * feat : Pawn 대각선 이동 구현 * feat : 처음에 start외 다른 명령어 입력시 예외 처리 구현 * refactor: turn 변경 camp 에 메서드 추가 * fix: 운영체제 별 줄바꿈 맞춤 * refactor: application 메서드 분리 * refactor: moving 레코드 안에 움직임 방향 확인 메서드 추가 * refactor : toString 사용 대체 * refactor : toString 재정의 * refactor : 방향 찾는 기능 Moving으로 이동 * test : Queen checkRoute Test * test: 퀸 이동 경로 확인 테스트 * test: 룩 이동 경로 확인 테스트 * test: 비숍 이동 경로 확인 테스트 * refactor : Pawn의 이동 검증 기능 GameBoard에서 Pawn으로 이동 * refactor: 테스트 하나로 합침 * refactor: getRoute 메서드 명 변경 및 board 메서드 분리 * refactor : 이동 경로 생성 메서드 중복 제거 * refactor: 이동 방향 인덱스 구하는 과정을 Direction enum 으로 이동 * refactor : PieceType 패키지 이동 * refactor : 인뎁스 감소 * refactor : Moving을 class로 변경 * feat: 재입력 기능 구현 * test : Knight 테스트 케이스 추가 * style : TODO 주석 제거 * refactor: controller 코드 메서드 분리 * style: todo 주석 제거 * refactor : 테스트 불변화 적용 * refactor: 메서드 및 변수에 final 추가 * docs: 기능 요구 사항 수정 * docs: 리팩터링 목록 추가 * test: Camp의 toggle 테스트 추가 * refactor: dto 메서드 분리 * test: moving의 방향 확인 테스트 추가 * feat: 유효하지 않은 포지션일 경우 예외 발생 기능 구현 * docs: 우선순위 낮은 구현 기능 목록 추가 * refactor: Position fixtures 생성 * feat: 커스텀 예외 추가하여 IllegalArgumentException 대체 * refactor: 게임 진행을 상태로 만들어 리팩터링 * refactor: row, column enum 명을 rank, file로 변경 * refactor: dto 변환 스트림 활용 * test: 상태 테스트 추가 * refactor: king 의 움직임 가능 확인 책임을 Moving으로 이동 * feat: 예외 시 재입력 기능 구현 * feat: 예외 메시지 출력 기능 구현 * docs: 게임 상태 및 명령어 설명 추가 * refactor: GameBoard 클래스명 ChessBoard로 변경 * refactor: Knight의 움직임 가능 확인 책임을 Moving으로 이동 * test: command 테스트 추가 * refactor: dto 변환 로직 스트림 활용 * feat: File 입력 시 대문자도 허용 * refactor: 컨트롤러의 메서드 책임 분리 * test: 기물들의 시작 위치 확인 * refactor: 파라미터, 변수 앞에 final 추가 * test: chessboard 테스트 보충 * test: pawn 움직임 테스트 추가 * test: running 예외 발생 테스트 추가 * style: 코드 포맷팅 수정 * refactor: ChessBoard 생성 시 바로 체스 기물 세팅 * refactor: 변수에 final 추가 * test: 움직이지 않을 경우 예외 테스트 추가 * refactor: 테스트 명 및 displayName 변경 * refactor: 명령어 인덱스 매직넘버 제거 * refactor: command 사이즈를 상수 대신 enum 필드로 변경 * refactor: dto에서 사용되는 매직넘버 상수화 * refactor: printCurrentCamp 메서드 명 변경 * docs: 완료한 리팩터링 목록 수정 * refactor: dto에 현재 턴 정보 포함 * refactor: List<String>이었던 커맨드들을 일급 컬렉션으로 변경 * refactor: dto 변환 스트림 대신 메서드 분리 * refactor: 불필요한 emtpy 커맨드 제거 * refactor: board를 일급 컬렉션으로 변경 및 책임 분리 * refactor: 게임 상태 생성 클래스 이름 변경 * refactor: pawn을 추상클래스로 변경하고 색마다 클래스 상속받는 형태로 변경 * fix: toString 메서드 제거 * refactor: 각 기물마다 예외 코드 세분화 * test: command body 확인 테스트 추가 * feat: 도착 지점에 아군이 있는 경우 ErrorCode 추가 * test: 해당 위치에 기물이 없는 경우 예외 발생 테스트 추가 * refactor: 점연산자 한줄에 여럿 있는 부분 분리 --------- Co-authored-by: unifolio0 <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d6a2ea5 - Browse repository at this point
Copy the full SHA d6a2ea5View commit details
Commits on Mar 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4a0d478 - Browse repository at this point
Copy the full SHA 4a0d478View commit details -
Configuration menu - View commit details
-
Copy full SHA for c7d94a6 - Browse repository at this point
Copy the full SHA c7d94a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6959778 - Browse repository at this point
Copy the full SHA 6959778View commit details -
Configuration menu - View commit details
-
Copy full SHA for f710580 - Browse repository at this point
Copy the full SHA f710580View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ede4eb - Browse repository at this point
Copy the full SHA 7ede4ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for df92d83 - Browse repository at this point
Copy the full SHA df92d83View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c33f96 - Browse repository at this point
Copy the full SHA 1c33f96View commit details -
Configuration menu - View commit details
-
Copy full SHA for df7b29a - Browse repository at this point
Copy the full SHA df7b29aView commit details
Commits on Mar 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 18337a8 - Browse repository at this point
Copy the full SHA 18337a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0735435 - Browse repository at this point
Copy the full SHA 0735435View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1430061 - Browse repository at this point
Copy the full SHA 1430061View commit details -
Configuration menu - View commit details
-
Copy full SHA for 525bdbb - Browse repository at this point
Copy the full SHA 525bdbbView commit details
Commits on Mar 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3f5078e - Browse repository at this point
Copy the full SHA 3f5078eView commit details -
Configuration menu - View commit details
-
Copy full SHA for ae56760 - Browse repository at this point
Copy the full SHA ae56760View commit details -
Configuration menu - View commit details
-
Copy full SHA for f0dbfbc - Browse repository at this point
Copy the full SHA f0dbfbcView commit details -
Configuration menu - View commit details
-
Copy full SHA for ccdf574 - Browse repository at this point
Copy the full SHA ccdf574View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e7a3db - Browse repository at this point
Copy the full SHA 1e7a3dbView commit details
Commits on Mar 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fd0debd - Browse repository at this point
Copy the full SHA fd0debdView commit details -
Configuration menu - View commit details
-
Copy full SHA for fc1d118 - Browse repository at this point
Copy the full SHA fc1d118View commit details -
Configuration menu - View commit details
-
Copy full SHA for c879ac5 - Browse repository at this point
Copy the full SHA c879ac5View commit details -
Configuration menu - View commit details
-
Copy full SHA for b3d1c8c - Browse repository at this point
Copy the full SHA b3d1c8cView commit details -
Configuration menu - View commit details
-
Copy full SHA for bbc0175 - Browse repository at this point
Copy the full SHA bbc0175View commit details -
Configuration menu - View commit details
-
Copy full SHA for 702f306 - Browse repository at this point
Copy the full SHA 702f306View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f3e9fe - Browse repository at this point
Copy the full SHA 6f3e9feView commit details -
Configuration menu - View commit details
-
Copy full SHA for c5694c3 - Browse repository at this point
Copy the full SHA c5694c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e2041e - Browse repository at this point
Copy the full SHA 5e2041eView commit details -
Configuration menu - View commit details
-
Copy full SHA for bd740d2 - Browse repository at this point
Copy the full SHA bd740d2View commit details
Commits on Mar 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for cb14f6d - Browse repository at this point
Copy the full SHA cb14f6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for a306cb2 - Browse repository at this point
Copy the full SHA a306cb2View commit details -
Configuration menu - View commit details
-
Copy full SHA for a4de87d - Browse repository at this point
Copy the full SHA a4de87dView commit details -
Configuration menu - View commit details
-
Copy full SHA for d75190f - Browse repository at this point
Copy the full SHA d75190fView commit details -
Configuration menu - View commit details
-
Copy full SHA for a3574f6 - Browse repository at this point
Copy the full SHA a3574f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b89a45 - Browse repository at this point
Copy the full SHA 6b89a45View commit details -
Configuration menu - View commit details
-
Copy full SHA for c00b9b9 - Browse repository at this point
Copy the full SHA c00b9b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 15265d0 - Browse repository at this point
Copy the full SHA 15265d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 44df19a - Browse repository at this point
Copy the full SHA 44df19aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 83ec223 - Browse repository at this point
Copy the full SHA 83ec223View commit details -
Configuration menu - View commit details
-
Copy full SHA for 90659cc - Browse repository at this point
Copy the full SHA 90659ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6183560 - Browse repository at this point
Copy the full SHA 6183560View commit details -
Configuration menu - View commit details
-
Copy full SHA for 394b828 - Browse repository at this point
Copy the full SHA 394b828View commit details -
Configuration menu - View commit details
-
Copy full SHA for 62e632a - Browse repository at this point
Copy the full SHA 62e632aView commit details -
Configuration menu - View commit details
-
Copy full SHA for b7881ec - Browse repository at this point
Copy the full SHA b7881ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for b680512 - Browse repository at this point
Copy the full SHA b680512View commit details -
Configuration menu - View commit details
-
Copy full SHA for c3200b3 - Browse repository at this point
Copy the full SHA c3200b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3687181 - Browse repository at this point
Copy the full SHA 3687181View commit details -
Configuration menu - View commit details
-
Copy full SHA for f21c948 - Browse repository at this point
Copy the full SHA f21c948View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e82363 - Browse repository at this point
Copy the full SHA 8e82363View commit details -
Configuration menu - View commit details
-
Copy full SHA for fc88a14 - Browse repository at this point
Copy the full SHA fc88a14View commit details -
Configuration menu - View commit details
-
Copy full SHA for 60644ad - Browse repository at this point
Copy the full SHA 60644adView commit details -
Configuration menu - View commit details
-
Copy full SHA for 719d55a - Browse repository at this point
Copy the full SHA 719d55aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a094e2f - Browse repository at this point
Copy the full SHA a094e2fView commit details
Commits on Apr 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 548cfa1 - Browse repository at this point
Copy the full SHA 548cfa1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 616c59c - Browse repository at this point
Copy the full SHA 616c59cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f6324e - Browse repository at this point
Copy the full SHA 0f6324eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b87987 - Browse repository at this point
Copy the full SHA 7b87987View commit details -
Configuration menu - View commit details
-
Copy full SHA for bfd2139 - Browse repository at this point
Copy the full SHA bfd2139View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ade17e - Browse repository at this point
Copy the full SHA 3ade17eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 54bd0e5 - Browse repository at this point
Copy the full SHA 54bd0e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e17f45 - Browse repository at this point
Copy the full SHA 2e17f45View commit details -
Configuration menu - View commit details
-
Copy full SHA for c3af772 - Browse repository at this point
Copy the full SHA c3af772View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.