chore: add xhr2 package #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@woodser please review :) |
bl4ck-cod3
reviewed
Dec 20, 2024
There was a problem hiding this comment.
All this does is override the XMLHttpRequest object that is being used with a global object. this introduces multiple other issues and does not solve the initial problem of XMLHttpRequest being called in specific places and being undefined. Furthermore global variables create a maintenance nightmare.
|
@woodser I thought it would be good to bundle xhr2 along so it comes with |
|
Moved to haveno-dex#339 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the error described in haveno-dex/haveno#1482.
To use:
npm installnpm packand install the packaged file in sample app
npm install haveno-ts-0.0.30.tgznpm run startYou will not see the
XMLHttpRequest is not definederror anymore