-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing order attribution metadata when using ECE #3629
Open
wjrosa
wants to merge
18
commits into
develop
Choose a base branch
from
fix/order-attribution-meta-missing-from-ece
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjrosa
requested review from
a team and
annemirasol
and removed request for
a team
November 29, 2024 12:55
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3022
Changes proposed in this Pull Request:
This PR fixes the inclusion of order attribution metadata when purchasing using express payment methods (with both Payment Request Buttons, PRB, and Express Checkout Element, ECE), both block checkout and shortcode checkout.
The solution consists in rendering the
<wc-order-attribution-inputs>
tag (native WooCommerce tag for this specific purpose) and populating it with data coming GET request. Then, merge the data with the existing order information (POST).Testing instructions
fix/order-attribution-meta-missing-from-ece
)?utm_source=Facebook
ECE Enabled
is_stripe_ece_enabled
totrue
.Block Checkout
Shortcode Checkout
ECE Disabled (PRB)
is_stripe_ece_enabled
tofalse
.Block Checkout
Shortcode Checkout
changelog.txt
andreadme.txt
(or does not apply)Post merge