ECE additional log #3618
Merged
ECE additional log #3618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mayisha
requested review from
a team and
wjrosa
and removed request for
a team
wjrosa
reviewed
Nov 22, 2024
wjrosa
reviewed
Nov 22, 2024
wjrosa
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had reports for PRBs that sites using SSL are also seeing
Stripe Payment Request live mode requires SSLin their logs.As per the is_ssl documentation, this may not work for sites behind load balancers.
Apart from that, this can happen to sites that do not have an automatic HTTP to HTTPS redirection rule on their server. If a shopper accesses their site in HTTP, it is expected to see the log for that page. In this PR, I have extended the log message for ECE so that it is clear from the logs which URL the shopper has hit (HTTP or HTTPS)
Testing instructions