Fixes _doing_it_wrong() messages being displayed on WordPress 6.7 due to translating too early

[mattallan]

Fixes #3604

Related P2: peNR48-111-p2

Changes proposed in this Pull Request:

After updating to WordPress 6.7, stores using our Stripe extension and have WP_Debug enabled will start seeing the following _doing_it_wrong notices across WP Admin pages:

In WordPress 6.7, they changed the way translations are loaded which affects how and when translation strings should be triggered. With this change, any __() code called before the after_setup_theme is considered "too early" and will need to be updated to happen on a later hook.

Part of the challenge with Stripe is that the entire plugin is inited on the 'plugins_loaded' hook (which is before after_setup_theme):

add_action( 'plugins_loaded', 'woocommerce_gateway_stripe_init' );

Digging through all of the files and classes included/initiated WC_Stripe->init() I found the following issues within Stripe:

• WC_Stripe_Privacy translated strings in the __construct(). Fixed in a4b1be2
• WC_Stripe_Settings_Controller was being instantiated with passing get_main_stripe_gateway() as the second parameter. This function builds the main Stripe gateway class which translates a bunch of strings. 5b88b55
• load_plugin_textdomain() was being called on plugins_loaded, this should happen on init 0361256

Testing instructions

To confirm the bug:

1. Make sure define( 'WP_DEBUG', true ); is set in wp-config
2. Update to the latest WordPress 6.7
3. Go to your Edit User Profile page and update the language to Español
   

There are two key areas of Stripe that these changes impact:

1. Privacy erasers/exporters

1. Go to WP Admin > Tools > Export personal data
2. Enter your email and manually download your personal data
3. Download and open zip -> index.html file
4. Under Customer Data heading, confirm "Stripe payment id" exists

2. Settings Controller

1. Go to WooCommerce > Settings > Payments > Stripe
2. Confirm no issues with loading the settings

---

• Covered with tests (or have a good reason not to test in description ☝️)
• Added changelog entry in both changelog.txt and readme.txt (or does not apply)
• Tested on mobile (or does not apply)

Post merge

• Added testing instructions to the Release Testing Instructions wiki page (or does not apply)
• Added the needs docs label (or does not apply)
• Included this PR in the Release Thread scope (or does not apply)

[wjrosa]

Code is good and works as expected:

Under Customer Data heading, confirm "Stripe payment id" exists

Confirm no issues with loading the settings