Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'is_live' value in account summary #3614

Merged
merged 4 commits into from
Nov 19, 2024
Merged

Conversation

Mayisha
Copy link
Contributor

@Mayisha Mayisha commented Nov 19, 2024

Fixes p1732003649743799-slack-C055WHLA98D

Changes proposed in this Pull Request:

Return 'is_live' as true in the account summary response when test mode is disabled in gateway settings and charge is enabled in the Stripe account.

Testing instructions

Code review should be enough.

@Mayisha Mayisha marked this pull request as draft November 19, 2024 09:02
@staskus
Copy link

staskus commented Nov 19, 2024

Thank you!

Before this change:

  • WP-Admin showed both Stripe extension and connected account are in Test Mode
  • However GET /?rest_route=/wc/v3/wc_stripe/account/summary&_fields=status%2Cis_live%2Ctest_mode returned is_live: true and test_mode: true for the site.

It prevented mobile app payments from being taken from the app.

After this change:

  • WP-Admin shows both Stripe extension and connected account are in Test Mode
  • GET /?rest_route=/wc/v3/wc_stripe/account/summary&_fields=status%2Cis_live%2Ctest_mode returns is_live: false and test_mode: true for the site.

Testing mobile app payments works as expected again.

@Mayisha Mayisha requested review from a team and wjrosa and removed request for a team November 19, 2024 10:05
@Mayisha Mayisha marked this pull request as ready for review November 19, 2024 10:05
Copy link
Contributor

@wjrosa wjrosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix, Mayisha! Code is good 👍

@Mayisha Mayisha merged commit 733fad6 into develop Nov 19, 2024
33 of 35 checks passed
@Mayisha Mayisha deleted the fix/is_live_in_account_summary branch November 19, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants