Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Link Autofill #3613

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Remove Link Autofill #3613

merged 3 commits into from
Nov 21, 2024

Conversation

annemirasol
Copy link
Contributor

@annemirasol annemirasol commented Nov 18, 2024

Fixes #3612

Changes proposed in this Pull Request:

Removes Link Autofill Modal, as part of the move to Link in the Payment Element.

Testing instructions

Objective: Test that Link autofill is no longer present, and nothing broke from the checkout process.

  1. Enable Link as a payment method.
  2. As a logged in shopper, add a product to cart and go to block checkout.
  3. For logged in shoppers, we expect the email address field to be pre-filled. Verify that the Link button is no longer there.
  4. Verify that you can finish purchasing your order without any problem.
  5. Repeat steps 2-5 for shortcode checkout.

Notes

  • With us no longer passing the Link autofill beta flag, if Link is enabled as a payment method, customers should see Link in their Payment Element. This is expected. Improvements to end-to-end experience will be addressed in a separate work.
User is signed out User is signed out (expanded) Prompt to sign up
Screenshot 2024-11-19 at 10 01 34 AM Screenshot 2024-11-19 at 10 02 17 AM Screenshot 2024-11-19 at 10 15 56 AM

  • Covered with tests (or have a good reason not to test in description ☝️)
  • Added changelog entry in both changelog.txt and readme.txt (or does not apply)
  • Tested on mobile (or does not apply)

Post merge

@annemirasol annemirasol marked this pull request as ready for review November 19, 2024 21:56
@annemirasol annemirasol requested review from a team and wjrosa and removed request for a team November 19, 2024 22:34
@annemirasol annemirasol self-assigned this Nov 20, 2024
Copy link
Contributor

@wjrosa wjrosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is good and it works as it should:
Screenshot 2024-11-21 at 08 48 58
Screenshot 2024-11-21 at 08 50 59

@annemirasol annemirasol merged commit f1da2be into develop Nov 21, 2024
34 of 35 checks passed
@annemirasol annemirasol deleted the remove/link-autofill branch November 21, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Link Autofill Modal
2 participants