[ECE] fix fatal error "Uncaught Error: Call to a member function get_total() on null" #3599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* enable ece feature flag by default for new accounts only * add changelog * call the method
annemirasol
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
✅ No more fatal when adding a new page
✅ No ECE button for block cart, block checkout and shortcode checkout, if cart total is 0.
Documenting here a related discovery, but I think should be a separate PR -- I still get ECE in shortcode cart even when cart total is 0. I do not get the EDIT: nvmIntegrationError that was present for the other pages, however.
From Slack conversations, you may want to rebase to |
diegocurbelo
pushed a commit
that referenced
this pull request
Nov 14, 2024
…total() on null" (#3599)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3598
Testing instructions
developbranch, notice that a fatal error occurs.