Fix ECE error for virtual products and when no shipping zones are set up #3595
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
In #3560, we fixed a scenario that causes ECE to crash on block checkout and block cart whenever the customer's ECE card address is not part of the shipping zones defined by the store. This however introduced a bug that causes a "Developer error" when there are no shipping methods set up, or when using ECE for virtual orders.
This PR fixes that behavior, such that:
Testing instructions
When there are no shipping methods defined, I can still use ECE to purchase shippable orders.
When there are shipping methods defined, but my ECE card address is not covered under shipping, I am asked in the modal to change my address for shippable orders.
My ability to purchase virtual orders via ECE should not be affected
changelog.txt
andreadme.txt
(or does not apply) -- skipped as this is technically part of Fix ECE crash when address has no defined shipping rates #3560Post merge