Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ECE deafult button and button position in shortcode cart page #3586

Merged
merged 5 commits into from
Nov 8, 2024

Conversation

Mayisha
Copy link
Contributor

@Mayisha Mayisha commented Nov 5, 2024

Changes proposed in this Pull Request:

Made two tiny design updates in this PR.

  1. Made the icon-only option the default one for express checkout buttons (like WooPayments). When you install the Stripe plugin on a new site and enable Google/Apple Pay, the default button will be icon-only.
  2. Fixed the ECE button position on the shortcode cart page.

Testing instructions

Case 1:

  • Build this branch and upload the zip to a fresh site (JN site). Enable Google/Apple pay and confirm that the default selected button type is icon only.

Case 2:

  • Install the PayPal plugin in your site and complete setup. (Instead of PayPal you may also use any other payment gateway that would show the payment button on the shortcode cart page).
  • Add a product to your cart and go to the shortcode cart page.
  • In develop branch, notice that the ECE button is placed above.
Screenshot 2024-10-28 at 11 32 43 PM
  • In this branch, confirm that the ECE button is placed with other payment buttons.
Screenshot 2024-10-28 at 11 41 00 PM

@Mayisha Mayisha requested review from a team and mattallan and removed request for a team November 5, 2024 15:31
Copy link
Contributor

@annemirasol annemirasol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢 🚢

  1. Making "Icon only" default for new installs: works as expected ✨
  2. Removing separator for shortcode cart: works as expected ✨

Listing some additional findings here -- I'm not really sure that these are issues. If you think they are, we can create separate trackers for them.

  1. I noticed that for ECE, "Icon only" vs "Buy" does not really change the Google Pay icon when the customer is logged in. "Donate" and "Book" change the button as expected. It works fine though when the customer is logged out.
Icon only (logged in) Buy (logged in) Donate Book
Screenshot 2024-11-07 at 12 29 08 PM Screenshot 2024-11-07 at 12 29 08 PM Screenshot 2024-11-07 at 12 29 22 PM Screenshot 2024-11-07 at 12 29 35 PM
  1. When all three are present, it looks like this for shortcode cart:
Screenshot 2024-11-07 at 12 37 26 PM

For comparison, it looks like this in block cart, i.e. each button in its own row:
Screenshot 2024-11-07 at 12 37 08 PM

@Mayisha
Copy link
Contributor Author

Mayisha commented Nov 8, 2024

Thanks @annemirasol

When all three are present, it looks like this for shortcode cart:

I will look into this 👀

@Mayisha Mayisha merged commit c97f908 into develop Nov 8, 2024
35 checks passed
@Mayisha Mayisha deleted the task/ece-design branch November 8, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants