Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing test mode class #3583

Merged
merged 6 commits into from
Nov 13, 2024
Merged

Introducing test mode class #3583

merged 6 commits into from
Nov 13, 2024

Conversation

wjrosa
Copy link
Contributor

@wjrosa wjrosa commented Nov 4, 2024

Following PR #3584

Changes proposed in this Pull Request:

Inspired by WooPayments, I changed how we check for test mode enabled by creating a new WC_Stripe_Mode class. It is a simple class but can replace many duplicated codes across the repository.

Testing instructions

Since this PR only introduces the new class, not implementing it yet, a code review is enough.


  • Covered with tests (or have a good reason not to test in description ☝️)
  • Added changelog entry in both changelog.txt and readme.txt (or does not apply)
  • Tested on mobile (or does not apply)

Post merge

@wjrosa wjrosa self-assigned this Nov 4, 2024
@wjrosa wjrosa marked this pull request as ready for review November 12, 2024 17:13
@wjrosa wjrosa requested review from a team and Mayisha and removed request for a team November 12, 2024 17:27
@wjrosa wjrosa mentioned this pull request Nov 12, 2024
6 tasks
Copy link
Contributor

@Mayisha Mayisha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@wjrosa wjrosa merged commit ad1e3bc into develop Nov 13, 2024
33 of 35 checks passed
@wjrosa wjrosa deleted the dev/introducing-test-mode-class branch November 13, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants