Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show ECE button in settings preview #3579

Merged
merged 7 commits into from
Nov 5, 2024
Merged

Conversation

Mayisha
Copy link
Contributor

@Mayisha Mayisha commented Nov 4, 2024

Fixes #3578

Changes proposed in this Pull Request:

  • Added ExpressCheckoutPreviewComponent component to display the ECE button on the settings page.
  • The component is created under client/entrypoints/payment-request-settings/. When we finally clean up the PRB codes, we will rename everything in this folder from payment-request to express-checkout-element.

Testing instructions

  • Go to the <your_site>/wp-admin/admin.php?page=wc-settings&tab=checkout&section=stripe&panel=methods&area=payment_requests page.
  • Enable the ECE feature flag and confirm that the ECE button is rendered.
  • Disable the ECE feature flag and confirm that the PRB button is rendered.

@Mayisha Mayisha changed the title create ece settings preview component Show ECE button in settings preview Nov 4, 2024
@Mayisha Mayisha requested review from a team, wjrosa and mattallan and removed request for a team and wjrosa November 4, 2024 14:52
Copy link
Contributor

@mattallan mattallan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes @Mayisha 💯

👍 Error notice image

👍 Google Pay ECE button

  • Changing "Call to action" updates preview
  • Changing "Size" updates preview
  • Changing "Theme" updates preview
    image

👍 Apple Pay in preview image

@Mayisha Mayisha merged commit 5c19485 into develop Nov 5, 2024
34 of 35 checks passed
@Mayisha Mayisha deleted the task/ece-settings-preview branch November 5, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ECE button in settings preview
2 participants