No longer record source migration failures in subscription order notes #3566
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3565
Changes proposed in this Pull Request:
This PR updates the
WC_Stripe_Subscriptions_Legacy_SEPA_Token_Update
class to make sure it doesn't attempt to migrate source objects which are cards.Stripe have confirmed they don't intend on migrating Source cards and so the note we were adding to subscriptions is confusing.
Testing instructions
git checkout 8.7.0
npm run build
pm_xxx
develop
, in the subscription's notes you should see the following note.Note added to a subscription after failing to migrate a source to a payment method.
changelog.txt
andreadme.txt
(or does not apply)Post merge