-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add QIT Custom E2E support and migrate tests #3555
Open
iamdharmesh
wants to merge
20
commits into
develop
Choose a base branch
from
feature/qit-e2e
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+554
−1,857
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
55fcdaa
Initial commit on migrating E2E tests to QIT custom E2E tests.
iamdharmesh a2506c9
Fix failing tests due to timeout.
iamdharmesh 86ea732
Fix flaky test by adding required wait.
iamdharmesh bb292d8
Remove unwanted files.
iamdharmesh 09a4526
Merge branch 'develop' into feature/qit-e2e
iamdharmesh bb15c61
Update E2E tests GH action workflow
iamdharmesh 7cdbf8b
Upgrade `woocommerce/qit-cli` to 0.7.1
iamdharmesh e95466d
Update tests to run from env vars pass by file as part of command ins…
iamdharmesh 1501802
Add script for upload test tags.
iamdharmesh ae9d5aa
Add GH action for the upload tests tags to QIT
iamdharmesh 4bb7584
Merge branch 'develop' of github.com:woocommerce/woocommerce-gateway-…
iamdharmesh 0b9493a
Temp: run upload tests GH action on PR.
iamdharmesh 30a4367
Update in upload tags script.
iamdharmesh 9fded93
Add debug code in upload tags script.
iamdharmesh 9791f6d
More debugging stuff
iamdharmesh 158bf7d
Remove debugging codes
iamdharmesh e68daf2
Readme updates related to E2E tests.
iamdharmesh 0508c77
Update E2E workflow to run with "WPP" activated and configured and up…
iamdharmesh 2413836
Upload only playwright folder of report to action artifact.
iamdharmesh 1dc5338
update timeout to fix flaky tests.
iamdharmesh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
name: Upload QIT E2E tests | ||
|
||
on: | ||
workflow_dispatch: | ||
release: | ||
types: [published] | ||
|
||
jobs: | ||
release: | ||
name: New release | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v4 | ||
|
||
- name: Set PHP version | ||
uses: shivammathur/setup-php@v2 | ||
with: | ||
php-version: 7.4 | ||
tools: composer:v2 | ||
coverage: none | ||
|
||
- name: Install QIT via composer | ||
run: composer require woocommerce/qit-cli | ||
|
||
- name: Add partner | ||
run: ./vendor/bin/qit partner:add --user='${{ secrets.PARTNER_USER }}' --application_password='${{ secrets.PARTNER_SECRET }}' | ||
|
||
- name: Upload E2E tests tags to QIT | ||
run: npm run test:upload-tags |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
{ | ||
"php_version": "7.4", | ||
"plugins": { | ||
"woocommerce": { | ||
"action": "bootstrap" | ||
}, | ||
"woocommerce-subscriptions": { | ||
"action": "bootstrap" | ||
} | ||
}, | ||
"themes": [ | ||
"storefront" | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pinging for review, I'm taking a look at it now and it's looking great overall.
Minor nit, but just to keep things dry you should be able to remove
npx playwright install
from thepostinstall
command inpackage.json
, now that this is handled by QIT.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This worked great for me. I've just cloned this repo, added my Stripe keys on the env file, and ran these:
nvm use
npm i
npm run build
npm run test:local
And this is the test report that it generated.
I've just noticed a little bit of flakiness in some of the assertions that can be improved in the future, just for increased reliability in the tests themselves.
QIT improved orchestration is in code review and will be merged sometime this week, when it does, we'd just need to rename
bootstrap.sh
tosetup.sh
andentrypoint.js
tosetup.js
.