fix: apply completion settings

Somehow this fell through the cracks. E2E tests only use the default
settings, and tests at the lower levels didn't catch the missing
link in the server.

packages/language-server/src/server.ts

@@ -156,6 +156,9 @@ export class SomeSassServer {
 					editorSettings,
 					workspaceRoot,
 					loadPaths: settings.loadPaths,
+					completionSettings: {
+						...settings,
+					},
 				});
 
 				workspaceScanner = new WorkspaceScanner(ls, fileSystemProvider, {
@@ -218,9 +221,17 @@ export class SomeSassServer {
 		this.connection.onDidChangeConfiguration((params) => {
 			if (!ls) return;
 
+			const somesassConfiguration: Partial<ISettings> =
+				params.settings.somesass;
+
 			const editorConfiguration: Partial<IEditorSettings> =
 				params.settings.editor;
 
+			const settings: ISettings = {
+				...defaultSettings,
+				...somesassConfiguration,
+			};
+
 			const editorSettings: IEditorSettings = {
 				insertSpaces: false,
 				indentSize: undefined,
@@ -231,6 +242,9 @@ export class SomeSassServer {
 			ls.configure({
 				editorSettings,
 				workspaceRoot,
+				completionSettings: {
+					...settings,
+				},
 			});
 		});
 

packages/language-services/src/features/__tests__/do-complete-node-modules.test.ts

@@ -0,0 +1,43 @@
+import { test, assert, beforeEach } from "vitest";
+import { getLanguageService } from "../../language-services";
+import { Position } from "../../language-services-types";
+import { getOptions } from "../../utils/test-helpers";
+
+const { fileSystemProvider, ...rest } = getOptions();
+const ls = getLanguageService({ fileSystemProvider, ...rest });
+
+beforeEach(() => {
+	ls.clearCache();
+	ls.configure({
+		completionSettings: {
+			suggestFromUseOnly: true,
+		},
+	}); // Reset any configuration to default
+});
+
+test("symbols forwarded from node_modules don't get suggested unless used", async () => {
+	const pkg = fileSystemProvider.createDocument(['{ "name": "test-module" }'], {
+		languageId: "json",
+		uri: "node_modules/sass-true/package.json",
+	});
+	const module = fileSystemProvider.createDocument(
+		["$catch-errors: false !default;"],
+		{
+			uri: "node_modules/sass-true/_throw.scss",
+		},
+	);
+	const forward = fileSystemProvider.createDocument(['@forward "sass-true";'], {
+		uri: "_test.scss",
+	});
+	const unrelated = fileSystemProvider.createDocument(["@debug $"]);
+
+	ls.parseStylesheet(module);
+	ls.parseStylesheet(forward);
+	ls.parseStylesheet(unrelated);
+
+	const { items } = await ls.doComplete(unrelated, Position.create(0, 8));
+	assert.notOk(
+		items.find((item) => item.label === "$catch-errors"),
+		"Expected not to find $catch-errors in suggestions",
+	);
+});