This repository has been archived by the owner on Mar 16, 2019. It is now read-only.
[WIP] Feature: parametrizable UI document interaction controller #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sending multiple requests in the same time
createJSModules was removedin React Native 0.47.0 and results in the attached Build Error. removing @OverRide fixes build (didn't remove function because I don't know if it should be kept for downard compatability?) ``` node_modules/react-native-fetch-blob/android/src/main/java/com/RNFetchBlob/RNFetchBlobPackage.java:23: error: method does not override or implement a method from a supertype @OverRide ^ 1 error Incremental compilation of 1 classes completed in 0.219 secs. :react-native-fetch-blob:compileReleaseJavaWithJavac FAILED FAILURE: Build failed with an exception. ```
Moreno97
changed the title
|
PR is at WIP ATM. |
added 2 commits
October 24, 2017 09:43
refs #51397 Added parameters to UIDocumentInteractionController refs #51397 Added parameters to UIDocumentInteractionController refs #51397 Added parameters to UIDocumentInteractionController
Moreno97
force-pushed
the
_parametrizable_ui_document_interaction_controller
branch
from
87fcc36
to
37d1e73
Compare
alvaromb
reviewed
Oct 24, 2017
alvaromb
suggested changes
Oct 24, 2017
ios/RNFetchBlob/RNFetchBlob.m
Outdated
| @@ -48,9 +48,9 @@ - (id) init { | |||
| self = [super init]; | |||
| self.filePathPrefix = FILE_PREFIX; | |||
| if(commonTaskQueue == nil) | |||
| commonTaskQueue = dispatch_queue_create("RNFetchBlob.queue", DISPATCH_QUEUE_SERIAL); | |||
| commonTaskQueue = dispatch_queue_create("RNFetchBlob.queue", DISPATCH_QUEUE_SERIAL); | |||
There was a problem hiding this comment.
Please add brackets ({}) to the if statement.
ios/RNFetchBlob/RNFetchBlob.m
Outdated
| @@ -32,7 +32,7 @@ @implementation RNFetchBlob | |||
|
|
|||
| - (dispatch_queue_t) methodQueue { | |||
| if(commonTaskQueue == nil) | |||
| commonTaskQueue = dispatch_queue_create("RNFetchBlob.queue", DISPATCH_QUEUE_SERIAL); | |||
| commonTaskQueue = dispatch_queue_create("RNFetchBlob.queue", DISPATCH_QUEUE_SERIAL); | |||
There was a problem hiding this comment.
Please add brackets ({}) to the if statement.
ios/RNFetchBlob/RNFetchBlob.m
Outdated
| if(fsQueue == nil) | ||
| fsQueue = dispatch_queue_create("RNFetchBlob.fs.queue", DISPATCH_QUEUE_SERIAL); | ||
| fsQueue = dispatch_queue_create("RNFetchBlob.fs.queue", DISPATCH_QUEUE_SERIAL); |
There was a problem hiding this comment.
Please add brackets ({}) to the if statement.
ios/RNFetchBlob/RNFetchBlob.m
Outdated
| @@ -154,35 +153,35 @@ - (NSDictionary *)constantsToExport | |||
| else { | |||
| fileContent = [[NSData alloc] initWithData:[data dataUsingEncoding:NSASCIIStringEncoding allowLossyConversion:YES]]; | |||
| } | |||
|
|
|||
|
|
|||
| BOOL success = [fm createFileAtPath:path contents:fileContent attributes:NULL]; | |||
| if(success == YES) | |||
There was a problem hiding this comment.
Please add brackets ({}) to the if statement.
ios/RNFetchBlob/RNFetchBlob.m
Outdated
| BOOL success = [fm createFileAtPath:path contents:fileContent attributes:NULL]; | ||
| if(success == YES) | ||
| callback(@[[NSNull null]]); | ||
| callback(@[[NSNull null]]); | ||
| else |
There was a problem hiding this comment.
Please add brackets ({}) to the if statement.
ios/RNFetchBlob/RNFetchBlob.m
Outdated
| if(error == nil) | ||
| callback(@[[NSNull null], @YES]); | ||
| callback(@[[NSNull null], @YES]); | ||
| else |
There was a problem hiding this comment.
Please add brackets ({}) to the if statement.
ios/RNFetchBlob/RNFetchBlob.m
Outdated
| @@ -418,12 +416,12 @@ - (NSDictionary *)constantsToExport | |||
| { | |||
| NSError * error = nil; | |||
| BOOL result = [[NSFileManager defaultManager] moveItemAtURL:[NSURL fileURLWithPath:path] toURL:[NSURL fileURLWithPath:dest] error:&error]; | |||
|
|
|||
|
|
|||
| if(error == nil) | |||
There was a problem hiding this comment.
Please add brackets ({}) to the if statement.
ios/RNFetchBlob/RNFetchBlob.m
Outdated
| if(error == nil) | ||
| callback(@[[NSNull null], @YES]); | ||
| callback(@[[NSNull null], @YES]); | ||
| else |
There was a problem hiding this comment.
Please add brackets ({}) to the if statement.
ios/RNFetchBlob/RNFetchBlob.m
Outdated
| @@ -467,11 +465,11 @@ - (NSDictionary *)constantsToExport | |||
| { | |||
| if(bufferSize == nil) { | |||
| if([[encoding lowercaseString] isEqualToString:@"base64"]) | |||
There was a problem hiding this comment.
Please add brackets ({}) to the if statement.
ios/RNFetchBlob/RNFetchBlob.m
Outdated
| @@ -467,11 +465,11 @@ - (NSDictionary *)constantsToExport | |||
| { | |||
| if(bufferSize == nil) { | |||
| if([[encoding lowercaseString] isEqualToString:@"base64"]) | |||
| bufferSize = 4095; | |||
| bufferSize = 4095; | |||
| else | |||
There was a problem hiding this comment.
Please add brackets ({}) to the if statement.
alvaromb
suggested changes
Oct 24, 2017
ios/RNFetchBlob/RNFetchBlob.m
Outdated
| green:((float)((rgbValue & 0x00FF00) >> 8))/255.0 \ | ||
| blue:((float)((rgbValue & 0x0000FF) >> 0))/255.0 \ | ||
| alpha:1.0]]; | ||
| [[UINavigationBar appearance] setBarTintColor: [UIColor whiteColor]]; |
There was a problem hiding this comment.
Please add the ability to set barTintColor too.
|
FYI react-native-fetch-blob has a new maintained location. Check out the README. Please consider submitting your PR there, this repository is unmaintained. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added parameters to UIDocumentInteractionController. This change allows you to change color and font type of iOS title bar.