Deprecate support for Node < 18 #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@benyebai can you fix the pipeline so that it builds with the correct node version? |
cmdshepard
requested changes
Jun 7, 2024
There was a problem hiding this comment.
Thanks for your PR!
But webpack is still transpiling for Node 6 so it doesn't address #38
I'm happy to accept a migration to Node 18 but if this is going to be the case, the module shouldn't serve transpiled file targeted to Node 6 anymore. I'm don't even think there is any value in having webpack and targeting Node 18+ since React projects have Babel or Webpack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Issue #38
Updated the minimum node version to 18.0.0
Fixed the workflow and changed the node version from 16.17 to 18.20.3