fixing video play button size on magnifying and expand mode #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liatv
approved these changes
Feb 11, 2024
| @@ -81,6 +80,8 @@ export default function MediaItem<T extends Record<string, any>>(props: MediaPro | |||
| return true; | |||
| } else if (clickAction === GALLERY_CONSTS[optionsMap.behaviourParams.item.clickAction].LINK && !hasLink) { | |||
| return true; | |||
| } else if (clickAction === 'ACTION' || clickAction === 'MAGNIFY') { | |||
There was a problem hiding this comment.
'ACTION' &&'MAGNIFY' - should be consts
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
liatv
suggested changes
Feb 14, 2024
There was a problem hiding this comment.
@IzaacAyelin @Galpittel
But aren't we missing the thumbnail arrow? Doesn't seems to be logical
liatv
reviewed
Feb 14, 2024
| @@ -45,7 +45,7 @@ export type MediaImplementationProps<T = {}> = T & | |||
|
|
|||
| const getPlayButtonComponentByItemType = (type: string) => { | |||
| if (type === 'video') { | |||
| return <GalleryUI type={'videoPlayButton'} size={12} />; | |||
| return <GalleryUI type={'videoPlayButton'} size={60} />; | |||
There was a problem hiding this comment.
we want to display size 12 for thumbnail
| } else if (clickAction === GALLERY_CONSTS[optionsMap.behaviourParams.item.clickAction].NOTHING) { | ||
| } else if ( | ||
| clickAction === GALLERY_CONSTS[optionsMap.behaviourParams.item.clickAction].NOTHING || | ||
| clickAction === GALLERY_CONSTS[optionsMap.behaviourParams.item.clickAction].MAGNIFY |
There was a problem hiding this comment.
if click action is NOTHING than why do we want to have the full video render? it's that means it's thumbnail?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.