Window wrapper mock #1161
Merged
Window wrapper mock #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhattav
reviewed
Aug 27, 2023
| @@ -130,6 +131,7 @@ export class GalleryContainer extends React.Component { | |||
| } | |||
|
|
|||
| componentDidMount() { | |||
| windowWrapper.isGalleryMounted = true; | |||
There was a problem hiding this comment.
wrap this in a function and think of the context. isGalleryMounted is the gallery's bussiness, not a windowWrapper logic. so the windowWrapper might have a flag that says useMock(or something like this) that could change to false after the gallery calls a function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
we want to use a partial window mock at the first client render
Why
we want the first render to use the mock values, same values used in the SSR response to prevent hydration issues
NOTE: the mock needed to be partial because we register to the window events listener when some of our components are mounted, the mocked properties on the client are dimensions and scroll