Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests requiring versioned checks #2536

Merged
merged 8 commits into from
Nov 21, 2024

Conversation

drcpu-github
Copy link
Collaborator

No description provided.

@drcpu-github drcpu-github changed the title Fix/fix/2527 Use versioned hash for block header in build_signed_empty_block test Nov 20, 2024
@drcpu-github drcpu-github force-pushed the fix/fix/2527 branch 5 times, most recently from 1040ad8 to 66b4f57 Compare November 20, 2024 16:04
ProtocolInfo is a global structure and setting protocol versions can result in concurrently running
tests failing. For example, test 1 started in protocol version 1.7, but test 2 changed the version
to 1.8 while test 1 was still running. Test 1 can now fail on versioned assertions.
@drcpu-github drcpu-github changed the title Use versioned hash for block header in build_signed_empty_block test Fix tests requiring versioned checks Nov 20, 2024
@aesedepece aesedepece merged commit a4929b1 into witnet:master Nov 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants