fix(session): allow synchronization across protocol version hot swaps #2522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aesedepece
force-pushed
the
fix-sync-across-protocols
branch
2 times, most recently
from
6f641c1
to
f83529e
Compare
aesedepece
force-pushed
the
fix-sync-across-protocols
branch
from
f83529e
to
995cd37
Compare
guidiaz
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Sessionactor includes logic that tells block candidates and inventory request responses apart by checking if the hash of the received block matches that of a former inventory request.That was breaking synchronization for the case where a protocol change happened in the middle of a synchronization chunk.
This PR acts by first checking versioned hashes first for the incumbent protocol version, and if it can't find it, it also checks it for the first upcoming protocol.