Implement clear wallet files #1883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabaldon
force-pushed
the
implement-clear-wallet
branch
5 times, most recently
from
db800a5
to
369faa9
Compare
Tommytrg
reviewed
Mar 21, 2024
electron/walletManager.ts
Outdated
| @@ -168,6 +173,26 @@ export class WalletManager { | |||
| } | |||
| } | |||
|
|
|||
| public clearWalletFiles(pathToClear: string) { | |||
| if (fs.existsSync(pathToClear)) { | |||
| const items = fs.readdirSync(pathToClear, { withFileTypes: true }) | |||
There was a problem hiding this comment.
Is it better to delete all files one by one instead of remove the .sheikah directory using fs.rmdirSync. IMO is less prone to error only try to delete once
gabaldon
force-pushed
the
implement-clear-wallet
branch
from
369faa9
to
f80ac0e
Compare
Tommytrg
reviewed
Mar 21, 2024
gabaldon
force-pushed
the
implement-clear-wallet
branch
2 times, most recently
from
1a0a039
to
68a5c20
Compare
gabaldon
force-pushed
the
implement-clear-wallet
branch
from
68a5c20
to
24cb22c
Compare
Tommytrg
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1868