Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue3 style changes #1869

Merged
merged 34 commits into from
Feb 6, 2024
Merged

Vue3 style changes #1869

merged 34 commits into from
Feb 6, 2024

Conversation

gabaldon
Copy link
Contributor

No description provided.

@gabaldon gabaldon force-pushed the feat/vue3 branch 2 times, most recently from ffcfb54 to e50c5f5 Compare January 24, 2024 13:02
Copy link
Member

@Tommytrg Tommytrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move the markdown style changnes to a different PR in master to make this easier to review?

Copy link
Member

@Tommytrg Tommytrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't run the app because "@vueuse/core" isn't in the package.json

.github/workflows/build.yaml Outdated Show resolved Hide resolved
.github/workflows/lintAndTest.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/components/RadonOperator.vue Show resolved Hide resolved
src/components/svg/DropdownExample.vue Outdated Show resolved Hide resolved
src/typings/idle-vue/index.d.ts Outdated Show resolved Hide resolved
src/App.vue Outdated Show resolved Hide resolved
src/components.d.ts Outdated Show resolved Hide resolved
src/components/SendTransaction/DeployDataRequest.vue Outdated Show resolved Hide resolved
src/components/SendTransaction/DeployDataRequest.vue Outdated Show resolved Hide resolved
src/components/Transaction.vue Show resolved Hide resolved
src/store/uiInteractions.js Outdated Show resolved Hide resolved
src/store/wallet.js Outdated Show resolved Hide resolved
src/store/wallet.js Outdated Show resolved Hide resolved
<!-- <transition :name="transitionName"> -->
<router-view />
<!-- </transition> -->
<router-view v-slot="{ Component }">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the comment above? I think we are already using a transition

src/components/AddressList.vue Outdated Show resolved Hide resolved
@Tommytrg
Copy link
Member

After creating a wallet, the created wallet doesn't load

Error

image

View

image

src/components/Templates.vue Outdated Show resolved Hide resolved
src/components/Templates.vue Show resolved Hide resolved
src/components/Templates.vue Outdated Show resolved Hide resolved
src/components/Transaction.vue Outdated Show resolved Hide resolved
src/components/card/TemplateCard.vue Outdated Show resolved Hide resolved
src/store/rad.js Show resolved Hide resolved
src/store/wallet.js Outdated Show resolved Hide resolved
src/styles/_colors.scss Outdated Show resolved Hide resolved
src/styles/element/index.scss Outdated Show resolved Hide resolved
src/styles/element/index.scss Outdated Show resolved Hide resolved
Copy link
Member

@Tommytrg Tommytrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got the following error after login out of the wallet:

api.js:137 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'total')
    at WalletApi.getTransactions (api.js:137:14)
    at async Store2.getTransactions (wallet.js:1082:23)

Copy link
Member

@Tommytrg Tommytrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got the following warning when clicking Show more button:

[Violation] Added non-passive event listener to a scroll-blocking 'touchstart' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952

image

@Tommytrg
Copy link
Member

The session is expired even when I've been using the app.

image

Copy link
Member

@Tommytrg Tommytrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix button style in resync modal:

image

src/components/NetworkStatus.vue Outdated Show resolved Hide resolved
@@ -120,7 +120,8 @@ export default {
color: $red-2;
font-size: 14px;
min-width: 270px;
position: absolute;
position: relative;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove this line

Suggested change
position: relative;

src/components/steps/Loading.vue Outdated Show resolved Hide resolved
Copy link
Member

@Tommytrg Tommytrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Priority doesn't work because we have to use 1.5.6 as the witnet-rust version: d7da386

Also, I think it could be related with the witnet-rust version, I'm getting the following error when sending a tx:

{"jsonrpc":"2.0","error":{"code":-32602,"message":"Invalid params: data did not match any variant of untagged enum StringOrInt.","data":{"schema":"https://github.com/witnet/witnet-rust/wiki/Create-Vtt"}},"id":161}

src/background/constants.ts Outdated Show resolved Hide resolved
src/components/EditorOperatorArgument.vue Outdated Show resolved Hide resolved
src/components/LogoutModal.vue Outdated Show resolved Hide resolved
@gabaldon gabaldon merged commit 143c0da into witnet:vue3 Feb 6, 2024
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants