-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vue3 style changes #1869
Vue3 style changes #1869
Conversation
ffcfb54
to
e50c5f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move the markdown style changnes to a different PR in master to make this easier to review?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't run the app because "@vueuse/core" isn't in the package.json
<!-- <transition :name="transitionName"> --> | ||
<router-view /> | ||
<!-- </transition> --> | ||
<router-view v-slot="{ Component }"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove the comment above? I think we are already using a transition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got the following error after login out of the wallet:
api.js:137 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'total')
at WalletApi.getTransactions (api.js:137:14)
at async Store2.getTransactions (wallet.js:1082:23)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -120,7 +120,8 @@ export default { | |||
color: $red-2; | |||
font-size: 14px; | |||
min-width: 270px; | |||
position: absolute; | |||
position: relative; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove this line
position: relative; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Priority doesn't work because we have to use 1.5.6 as the witnet-rust version: d7da386
Also, I think it could be related with the witnet-rust version, I'm getting the following error when sending a tx:
{"jsonrpc":"2.0","error":{"code":-32602,"message":"Invalid params: data did not match any variant of untagged enum StringOrInt.","data":{"schema":"https://github.com/witnet/witnet-rust/wiki/Create-Vtt"}},"id":161}
No description provided.