Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-organize test files #351

Merged
merged 4 commits into from
Aug 29, 2023
Merged

Re-organize test files #351

merged 4 commits into from
Aug 29, 2023

Conversation

gabaldon
Copy link
Contributor

  • Fix get_account_preferences_test to check if it is an hd wallet account

close #322

Copy link
Member

@Tommytrg Tommytrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rename the commits with:

  • chore(tests): reorganize test files
  • refactor(account_preferences): improve AccountPreferencesParams testability

@Tommytrg
Copy link
Member

Could you move to a different commit the fix done in test/util/transactions_list/get_transaction_address_test.dart and review the test text? The title says that the expected result of that test should be "Several addresses" and we are adding an address

@gabaldon gabaldon merged commit 03d1af0 into witnet:main Aug 29, 2023
6 checks passed
@gabaldon gabaldon temporarily deployed to github-pages August 29, 2023 13:56 — with GitHub Pages Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-organize test files
2 participants