Per deposit accounting #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apbendi
force-pushed
the
per-deposit-accounting
branch
from
06d913a to
aae0398
Compare
apbendi
commented
Sep 24, 2024
| @@ -130,13 +130,23 @@ contract GovernanceStakerTest is Test, PercentAssertions { | |||
| view | |||
There was a problem hiding this comment.
arbitrary comment location
Note that I've created a number of follow up issues to expand the test suite and make other modifications that flow from this PR, but which can be handled independent of it.
- Rewrite "sum of rewards" invariant #15
- Rewrite "sum of earning power" invariant for updated accounting/earning power system #16
- Consider: Rename the deposit's beneficiary to something more descriptive #17
- Add additional tests for the new purpose of a deposits beneficiary #18
- Should the owner of a deposit also be able to claim its rewards? #19
apbendi
force-pushed
the
per-deposit-accounting
branch
from
aae0398 to
1b75abc
Compare
UniStaker tracks rewards earned by individual addresses which are specified as the beneficiary of deposits. The same address may earn rewards from tokens which have been staked in multiple deposits. This commit converts the system to track rewards on a per-deposit basis instead. Each deposit earns rewards according to the tokens staked in it. The test suite has been updated to reflect this change. The meaning of beneficiary changed as well. It is no longer the address that earns the rewards, but instead is the address that has permissions to withdrawal the rewards earned by a given deposit. Co-Author: Keating <[email protected]>
apbendi
force-pushed
the
per-deposit-accounting
branch
from
8ea6f48 to
f26956a
Compare
|
Coverage after merging per-deposit-accounting into main will be
Coverage Report
|
|||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5