Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugins): add Starlight Ion theme #2620

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Ast3risk-ops
Copy link

Description

Added the Starlight Ion theme since it's featured on https://astro.build (themes section > docs) yet for some reason it's not showcased in the Starlight docs.

image

I did not make this theme.

Copy link

changeset-bot bot commented Nov 21, 2024

⚠️ No Changeset found

Latest commit: 1ec5ceb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the 📚 docs Documentation website changes label Nov 21, 2024
Copy link

netlify bot commented Nov 21, 2024

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 1ec5ceb
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/6744c838ed428d00088562bf
😎 Deploy Preview https://deploy-preview-2620--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Collaborator

Hello! Thank you for opening your first PR to Starlight! ✨

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🤩

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@astrobot-houston
Copy link
Collaborator

astrobot-houston commented Nov 21, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en resources/plugins.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@Ast3risk-ops Ast3risk-ops changed the title Add Starlight Ion theme feat(plugins): add Starlight Ion theme Nov 21, 2024
Copy link
Contributor

@trueberryless trueberryless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your first contribution to Starlight, @Ast3risk-ops!

Everything looks good to me!
(The additional four spaces will be formatted by the CI formater)

@delucis
Copy link
Member

delucis commented Nov 22, 2024

Thanks for sharing this! I think the reason this hasn’t been included so far is that it isn’t a Starlight plugin, which is what this page is focused on:

A theme is a Starlight plugin that changes the visual appearance of a site with component overrides, custom CSS, or other new features.

It looks very cool, but Ion is a template repository that includes custom components and overrides hardcoded rather than a plugin you install and extend Starlight with. That’s not necessarily a bad thing — it makes Ion’s components very flexible when you copy the template because you can edit them directly in your project. But it does mean we may need to think for a second how best to showcase it.

@trueberryless
Copy link
Contributor

Thanks for sharing this! I think the reason this hasn’t been included so far is that it isn’t a Starlight plugin.

My bad, I didn't look into this aspect thoroughly enough.

@delucis
Copy link
Member

delucis commented Nov 25, 2024

I guess one option could be to add https://louisescher.github.io/starlight-ion-theme/ to the Site Showcase instead? At least it would be linked that way.

@Ast3risk-ops
Copy link
Author

I guess one option could be to add louisescher.github.io/starlight-ion-theme to the Site Showcase instead? At least it would be linked that way.

It's not a site using starlight though, it's a set of components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 docs Documentation website changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants