Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix next basics #12396

Open
wants to merge 2 commits into
base: next
Choose a base branch
from
Open

Fix next basics #12396

wants to merge 2 commits into from

Conversation

TheOtterlord
Copy link
Member

Changes

Adds missing layout CSS. Doesn't add the gradient back because the full title is a prop.

Testing

N/A

Docs

N/A

Copy link

changeset-bot bot commented Nov 7, 2024

⚠️ No Changeset found

Latest commit: a0f23e6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@TheOtterlord TheOtterlord changed the base branch from main to next November 7, 2024 21:23
@github-actions github-actions bot added pkg: example Related to an example package (scope) semver: minor Change triggers a `minor` release labels Nov 7, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

Copy link

codspeed-hq bot commented Nov 7, 2024

CodSpeed Performance Report

Merging #12396 will not alter performance

Comparing fix-next-basics (c6e7d78) with main (e10b03e)

Summary

✅ 1 untouched benchmarks

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) and removed pkg: example Related to an example package (scope) labels Nov 8, 2024
Copy link
Member

@Princesseuh Princesseuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not super optimal, but since I'll be reworking it soon, as long as it works right now it's fine with me

@Princesseuh
Copy link
Member

ah, the test catches what Chris brought up regarding styles leaking. We'll rework the template to use a direct import instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) semver: minor Change triggers a `minor` release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants