fix: 404 and 500 route matching #12182
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1313505 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
1 task
|
@braden-w can you look at the tests? They are failing |
|
Hmm unsure how to proceed, the errors seem a bit cryptic and unrelated to my changes. Is there anyone who might be well-suited for some guidance on how to read these?
|
|
The issue is that you imported I suggest moving those functions inside |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Standardize 404 and 500 route matching via
isRoute404andisRoute500functions.Closes #11595
I'm unsure where are the best places to put the
isRoute404andisRoute500functions, so I put them inpackages/astro/src/core/util.tsfor now with other util filesThey could be moved!
They are used in
packages/astro/src/i18n/index.tsandpackages/astro/src/vite-plugin-astro-server/route.tsTesting
No tests were added as no new behavior was added. Ran
pnpm teston theastropackage viapnpm --filter astro run test.Docs
n/a, this is a fix in behavior that addresses #11595