Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[charts] Fix staging configuration #4338

Merged
merged 3 commits into from
Nov 13, 2024
Merged

[charts] Fix staging configuration #4338

merged 3 commits into from
Nov 13, 2024

Conversation

elland
Copy link
Contributor

@elland elland commented Nov 13, 2024

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

elland
elland commented Nov 13, 2024
View reviewed changes
charts/brig/templates/configmap.yaml
@@ -92,7 +93,6 @@ data:
caCert: /etc/wire/brig/rabbitmq-ca/{{ .tlsCaSecretRef.key }}
{{- end }}
{{- end }}
{{- end }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rabbitmq was declared inside of '{{- if .enableFederation }}. Moved the closing {{- end }}` up to federator only.

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Nov 13, 2024
@elland elland marked this pull request as ready for review November 13, 2024 09:41
@elland elland merged commit 7f426d6 into develop Nov 13, 2024
10 checks passed
@elland elland deleted the fix/charts-for-rabbit branch November 13, 2024 10:23
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdimjasevic mdimjasevic mdimjasevic approved these changes

Assignees
No one assigned
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elland @mdimjasevic @zebot