Skip to content

Commit

Permalink
fix: Revert to quit for locale change on macOS (#960)
Browse files Browse the repository at this point in the history
  • Loading branch information
Gregor Herdmann authored Sep 21, 2017
1 parent 0b5e112 commit 64d82bb
Showing 1 changed file with 9 additions and 5 deletions.
14 changes: 9 additions & 5 deletions electron/js/menu/system.js
Original file line number Diff line number Diff line change
Expand Up @@ -497,13 +497,17 @@ function changeLocale(language) {
type: 'info',
title: locale[language].restartNeeded,
message: locale[language].restartLocale,
buttons: [locale[language].restartLater, locale[language].restartNow],
buttons: [locale[language].restartLater, process.platform === 'darwin' ? locale[language].menuQuit : locale[language].restartNow],
}, function(response) {
if (response === 1) {
app.relaunch();
// Using exit instead of quit for the time being
// see: https://github.com/electron/electron/issues/8862#issuecomment-294303518
app.exit();
if (process.platform === 'darwin') {
app.quit();
} else {
app.relaunch();
// Using exit instead of quit for the time being
// see: https://github.com/electron/electron/issues/8862#issuecomment-294303518
app.exit();
}
}
});
}
Expand Down

0 comments on commit 64d82bb

Please sign in to comment.