replay log on initialize #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ah-
reviewed
May 1, 2018
| assert keys == [b'a', b'b', b'a'] | ||
| assert values == [b'\x0c\0\0\0', b'\x7b\0\0\0', b''] | ||
|
|
||
|
|
There was a problem hiding this comment.
Am I missing something_ Where exactly does it replay into the actual store from the changelog?
There was a problem hiding this comment.
ChangeLoggingStateStore.initialize?
There was a problem hiding this comment.
Ah. Hooking that up with stream task is another PR?
There was a problem hiding this comment.
A StreamTask calles StateStore.initialize(context, root) as part of its init(). The if the StateStore is a ChangeLoggingStateStore then it will replay the changelog into it's inner_state_store. See change_logging_state_store.py:25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replays State topic to rebuild local state on start.