Add clrmamepro manifest #58
Conversation
|
Hello, thanks for the contribution. Can we simplify the app-id to |
|
@julianrichen Of course we can. Updated! |
| <url type="help">https://mamedev.emulab.it/clrmamepro/docs/index.htm</url> | ||
|
|
||
| <categories> | ||
| <category>Game</category> |
There was a problem hiding this comment.
I think System;Emulator; categories might be better. So
<categories>
<category>System</category>
<category>Emulator</category>
</categories>
| Terminal=false | ||
| Type=Application | ||
| MimeType=application/x-ms-dos-executable;application/x-msi;application/x-ms-shortcut; | ||
| Categories=Game |
There was a problem hiding this comment.
Like the appdata lets do System;Emulator;.
| Type=Application | ||
| MimeType=application/x-ms-dos-executable;application/x-msi;application/x-ms-shortcut; | ||
| Categories=Game | ||
| Keywords=Game;Emulation; |
There was a problem hiding this comment.
ROMs aren't exclusive to games so maybe do Emulator;Editor;Manager;?
| - mkdir -p /app/lib/32bit | ||
| - ln -s /app/lib/32bit/lib/ld-linux.so.2 /app/lib/ld-linux.so.2 | ||
|
|
||
| - name: setup-wine |
There was a problem hiding this comment.
This module isn't needed since you're not mounting another Wine extension. This was a mistake in the Notepad++ manifest. My bad, sorry.
| - type: file | ||
| path: it.emulab.mamedev.clrmamepro.desktop | ||
| - type: file | ||
| path: icons/it.emulab.mamedev.clrmamepro.48x48.png |
There was a problem hiding this comment.
Does clrmamepro happen to have icons at 128px & 64px? Trying to follow Flathub's packaging guide on icon requirements but if not, no worries.
There was a problem hiding this comment.
It does not. It does have one for 16x16 but it is entirely broken-looking so not included.
|
Sorry, I had reviewed the pr but didn't actually submit the review so you could see it... so 5 comments where missing. I added a few more things I would like updated. Icons is a nitpick so ignore if you can't find larger. |
New application: clrmamepro
https://mamedev.emulab.it/clrmamepro/
Adapted from the Notepad++ manifest.