Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding StarCraft to WinePak #121

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adding StarCraft to WinePak #121

wants to merge 2 commits into from

Conversation

Isakku
Copy link

@Isakku Isakku commented Aug 14, 2018

Changed icon and scripts, testing is required.
Followed @Saroufim instructions here
#116 (comment)
I'm no expert with Wine or Flatpak, this is my first pull request here.

Changed icon and  scripts, testing is required.
@Isakku
Copy link
Author

Isakku commented Aug 15, 2018

Add the correct icon https://us.shop.battle.net/static/3.2.1/images/family-icons/starcraft-remastered.svg

Lol, and that's the icon we are supposed to use? I really liked the Terran Wraith that SC1 had and I loved that new Wraith redesign they supplied with 1.16, but now they give us this bland SC letters... sigh OK, I'm doing it.

EDIT
Hmm. while we are at it, could you please tell me how do you test this? I mean, how do you test winepak scripts that are offline and were made by yourself with mostly possible horrific bugs without breaking your system (I already found a bug with SC2 winepak) #122
When I was editing it to make the SC1 script I noticed that it changes Wine graphics mode to opengl... I don't know why. Lutris SC2 install script does many other different things but nothing like that.

Lol, and that's the icon we are supposed to use? I really liked the Terran Wraith that SC1 had and I loved that new Wraith redesign they supplied with 1.16, but now they give us this bland SC letters... sigh OK, I'm doing it.
@Isakku
Copy link
Author

Isakku commented Oct 24, 2018

There is really no way I can make this work if the code It is based on (StarCraft II Winepak) fails on my side (issue #122)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant