PP-136/smart wallet transfer #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding .env config on readme and fix some tests. * Throw an error if not metamask detected. * Adding loading modal * Removing test recipients from .env. * Adding execute modal. * Fixing multiple issues * Replacing send by sendtransactions * Fix to use relayTransaction * revert to infuy sdk * Adding loading on buttons * Clear modal form inputs * PP-92: Fix open issues (#1) * Remove "REACT_APP_RIF_RELAY_RELAY_LOOKUP_WINDOW_BLOCKS" from .env * [Devops] Adding initial dockerfile (#2) * Add the 'estimate' button on transfer modal plus further UI fixes (#7) * Fix the shared status between the estimate and execute buttons. * Fix the return data slide button in the execute modal * Fix estimate loading on deploy modal * Add the estimation button and show the rbtc/trif switch * PP-118: Set the retries param when relaying transfer transactions (#8) * Set the param on transfer * Specify how to retrieve the REACT_APP_CONTRACTS_RELAY_WORKER parameter Co-authored-by: Wilson hamilton <[email protected]> Co-authored-by: mortelli <[email protected]> Co-authored-by: rafaiovlabs <[email protected]>
* Install dependencies * Convert js files to tsx * Fix lint problems not related to formatting * Add prettier, fix prettier problems and solve conflicts with eslint * Fix lint issues on tsx files * Add lint-staged * Remove useless comment * Fix transfer estimation error
* feature (devops): add ci steps for linting * Run prettier fix for CI
|
Close this PR in favor of the one against the official repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Removed the process where native cryptocurrency balance is transfer back to the owner EOA
Why
It would be more consistent (simpler, in UX terms) to leave the native cryptocurrency balance in the SmartWallet instead of transferring it to the owner EOA after each execution.
Refs