Add isValidAAEntrypoint and isWalletASmartWallet Onchain Kit utilities #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cpcramer is attempting to deploy a commit to the wilsoncusack's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@cpcramer is this ready to merge? |
cpcramer
force-pushed
the
paul/add-isValidAAEntrypoint-and-isWalletASmartWallet
branch
from
1b94f4f to
7ad8967
Compare
cpcramer
changed the title
|
Ready to merge |
| // check entrypoint | ||
| // not strictly needed given below check on implementation address, but leaving as example | ||
| if (entrypoint.toLowerCase() !== ENTRYPOINT_ADDRESS_V06.toLowerCase()) | ||
| if (!isValidAAEntrypoint({ entrypoint } as IsValidAAEntrypointOptions)) |
There was a problem hiding this comment.
@cpcramer in this case I want to check if it is specifically version 6
There was a problem hiding this comment.
It checks for v6 but we should probably make that more explicit!
| )[0]; | ||
| if (implementationAddress != coinbaseSmartWalletV1Implementation) | ||
| if ( | ||
| !(await isWalletASmartWallet({ |
There was a problem hiding this comment.
Do we want this to be isWalletACoinbaseSmartWallet just to be really clear?
There was a problem hiding this comment.
Yeah I think that's a good call. I'll update
There was a problem hiding this comment.
Updating here coinbase/onchainkit#562
DashaBochkar
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
isValidAAEntrypointandisWalletASmartWalletOnchain Kit utilities to theTransact With Paymasterdemo.isValidAAEntrypointhttps://onchainkit.xyz/wallet/is-valid-aa-entrypointisWalletASmartWallethttps://onchainkit.xyz/wallet/is-wallet-a-smart-wallet