Draft #67
Draft
Draft #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esults adding support for snippeted results
…esults Adding a custom sorting function, and adding Content to be indexed
wilr
reviewed
May 10, 2024
src/Service/AlgoliaQuerier.php
Outdated
| //This will unset all results that aren't guide pages | ||
| //Then instantly re add to array which places them at the bottom. | ||
| foreach($records as $key => $wanted) { | ||
| if($wanted->ClassName != 'IntranetGuidePage') { |
There was a problem hiding this comment.
@phillygogo Definitely should not be done in here :) Sorting can be set in Algolia directly.
mitch-harty
reviewed
May 12, 2024
| @@ -68,6 +68,20 @@ function array_key_first(array $arr) | |||
| $record = $className::get()->byId($id); | |||
|
|
|||
| if ($record && $record->canView()) { | |||
| // Snippet results are cofigured in Algolia to be returned. | |||
| // Since the following result is actually fetched from the DB | |||
| // I need to concatenate the aogolias snippeted result to the $hit to be returned | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draf