Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MongoClient.connect: url without database defaults to admin db #87

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

philippevk
Copy link

In the current mongo-mock version, specifying a connect url without any database throws an error.

The mongo documentation says it should default to admin db: https://mongodb.github.io/node-mongodb-native/driver-articles/mongoclient.html#basic-parts-of-the-url

Copy link
Collaborator

@angelo-hub angelo-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems good to me can you add a unit test for it?

@zardilior
Copy link

Is this closed?

@angelo-hub
Copy link
Collaborator

Is this closed?

Nah, I might just update the pull request myself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants