This repository has been archived by the owner on Jan 31, 2022. It is now read-only.
Feature bump php #32
Open
Feature bump php #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DavidGoodwin
commented
Apr 3, 2019
DavidGoodwin
commented
- Update phpunit to avoid PHP 7.x warnings
- Update travis to add PHP 7.x
- Update composer to have PHP >= 5.6
peter279k
reviewed
Apr 19, 2019
| @@ -258,7 +258,7 @@ public function testScanWithUserTimeout() | |||
| */ | |||
| public function testExecutableNotExecutable() | |||
| { | |||
| $executor = $this->getMock('Nmap\Util\ProcessExecutor'); | |||
| $executor = $this->createMock('Nmap\Util\ProcessExecutor'); | |||
There was a problem hiding this comment.
If upgrading the PHP version to php-5.6+, the class instance string can use the ::class magic method approach.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.